Re: Review Request 33376: MESOS-2633 Moved struct Framework methods to their own implementation class.

2015-04-30 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33376/ --- (Updated April 30, 2015, 9:44 p.m.) Review request for mesos and Joris Van

Re: Review Request 33376: MESOS-2633 Moved struct Framework methods to their own implementation class.

2015-04-29 Thread Marco Massenzio
On April 29, 2015, 8:24 p.m., Joris Van Remoortere wrote: src/master/framework.cpp, line 187 https://reviews.apache.org/r/33376/diff/3/?file=939881#file939881line187 1) Let's sync with BenH if we want to factor out logging like this. There are arguments on both sides, so let's

Re: Review Request 33376: MESOS-2633 Moved struct Framework methods to their own implementation class.

2015-04-29 Thread Ben Mahler
On April 29, 2015, 8:24 p.m., Joris Van Remoortere wrote: I was surprised to see new functionality in this patch since the summary was code movement :) Just a quick note on DRY below. On April 29, 2015, 8:24 p.m., Joris Van Remoortere wrote: src/master/framework.cpp, line 187