---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34136/#review93481
---
include/mesos/mesos.proto (line 1213)
On July 14, 2015, 9:03 p.m., Jiang Yan Xu wrote:
include/mesos/mesos.proto, lines 1211-1213
https://reviews.apache.org/r/34136/diff/3/?file=1009139#file1009139line1211
So I found the use of the field `id` inconsistent in the code.
Sometimes `id` has the `sha512-` prefix
On July 14, 2015, 9:03 p.m., Jiang Yan Xu wrote:
include/mesos/mesos.proto, lines 1211-1213
https://reviews.apache.org/r/34136/diff/3/?file=1009139#file1009139line1211
So I found the use of the field `id` inconsistent in the code.
Sometimes `id` has the `sha512-` prefix
On July 14, 2015, 2:03 p.m., Jiang Yan Xu wrote:
include/mesos/mesos.proto, lines 1211-1213
https://reviews.apache.org/r/34136/diff/3/?file=1009139#file1009139line1211
So I found the use of the field `id` inconsistent in the code.
Sometimes `id` has the `sha512-` prefix
On July 14, 2015, 9:03 p.m., Jiang Yan Xu wrote:
include/mesos/mesos.proto, lines 1211-1213
https://reviews.apache.org/r/34136/diff/3/?file=1009139#file1009139line1211
So I found the use of the field `id` inconsistent in the code.
Sometimes `id` has the `sha512-` prefix
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34136/#review91666
---
Sorry I didn't notice it in my original review but I traced the
On June 26, 2015, 2:57 p.m., Jiang Yan Xu wrote:
include/mesos/mesos.proto, lines 1212-1214
https://reviews.apache.org/r/34136/diff/2/?file=989752#file989752line1212
Is it the intention that Image type is **defined** outside MesosInfo
because DockerInfo can later reference it?
On June 25, 2015, 3:32 p.m., Paul Brett wrote:
include/mesos/mesos.proto, line 1221
https://reviews.apache.org/r/34136/diff/2/?file=989752#file989752line1221
Mesos info is optional, but if present can optionally contain an image?
So what does a mesos present with a MesosInfo
On June 26, 2015, 2:57 p.m., Jiang Yan Xu wrote:
include/mesos/mesos.proto, lines 1212-1214
https://reviews.apache.org/r/34136/diff/2/?file=989752#file989752line1212
Is it the intention that Image type is **defined** outside MesosInfo
because DockerInfo can later reference it?
On June 26, 2015, 9:57 p.m., Jiang Yan Xu wrote:
include/mesos/mesos.proto, lines 1212-1214
https://reviews.apache.org/r/34136/diff/2/?file=989752#file989752line1212
Is it the intention that Image type is **defined** outside MesosInfo
because DockerInfo can later reference it?
On June 25, 2015, 10:32 p.m., Paul Brett wrote:
include/mesos/mesos.proto, line 1221
https://reviews.apache.org/r/34136/diff/2/?file=989752#file989752line1221
Mesos info is optional, but if present can optionally contain an image?
So what does a mesos present with a MesosInfo
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34136/#review91002
---
Ship it!
LGTM.
include/mesos/mesos.proto (line 1220)
On June 25, 2015, 10:32 p.m., Paul Brett wrote:
include/mesos/mesos.proto, line 1221
https://reviews.apache.org/r/34136/diff/2/?file=989752#file989752line1221
Mesos info is optional, but if present can optionally contain an image?
So what does a mesos present with a MesosInfo
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34136/#review90166
---
include/mesos/mesos.proto (line 1209)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34136/#review89577
---
include/mesos/mesos.proto (lines 1212 - 1214)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34136/#review89438
---
include/mesos/mesos.proto (line 1196)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34136/#review89226
---
Ship it!
Ship It!
- Timothy Chen
On June 22, 2015, 4:42 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34136/#review83823
---
include/mesos/mesos.proto
18 matches
Mail list logo
