---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34256/#review88979
---
Ship it!
3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34256/#review88998
---
Ship it!
much cleaner. thank you!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34256/
---
(Updated June 23, 2015, 8:26 a.m.)
Review request for mesos and Cody Maloney.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34256/
---
(Updated June 24, 2015, 2:44 a.m.)
Review request for mesos and Cody Maloney.
On June 23, 2015, 5:29 p.m., Vinod Kone wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp, line 76
https://reviews.apache.org/r/34256/diff/7/?file=990278#file990278line76
don't you want to do the same short circuit as in basename() for path
containing only slashes?
On June 23, 2015, 2:37 p.m., Kapil Arya wrote:
3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp, lines 40-52
https://reviews.apache.org/r/34256/diff/7/?file=990279#file990279line40
It probably applies to the Class itself, but should we also be testing
for repeated middle
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34256/
---
(Updated June 5, 2015, 1:03 p.m.)
Review request for mesos and Cody Maloney.
On May 19, 2015, 8:07 p.m., Vinod Kone wrote:
3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp, line 29
https://reviews.apache.org/r/34256/diff/4/?file=962202#file962202line29
nice tests.
Can I drop this issue :)?
On May 19, 2015, 8:07 p.m., Vinod Kone wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34256/#review84375
---
3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp
