Re: Review Request 34268: stout library - adding support for Solaris

2015-06-02 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34268/#review86172 --- Ship it! Ship It! - Till Toenshoff On May 22, 2015, 7:15 p.m.,

Re: Review Request 34268: stout library - adding support for Solaris

2015-06-01 Thread Till Toenshoff
On June 1, 2015, 10:36 a.m., Till Toenshoff wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp, lines 71-82 https://reviews.apache.org/r/34268/diff/2/?file=969835#file969835line71 Seems we got some options here; A. use your separate, stream-based approach for

Re: Review Request 34268: stout library - adding support for Solaris

2015-06-01 Thread Stan Teresen
On June 1, 2015, 10:36 a.m., Till Toenshoff wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp, lines 71-82 https://reviews.apache.org/r/34268/diff/2/?file=969835#file969835line71 Seems we got some options here; A. use your separate, stream-based approach for

Re: Review Request 34268: stout library - adding support for Solaris

2015-05-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34268/#review84974 --- Patch looks great! Reviews applied: [34268] All tests passed. -

Re: Review Request 34268: stout library - adding support for Solaris

2015-05-22 Thread Stan Teresen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34268/#review85054 --- Ship it! Ship It! - Stan Teresen On May 22, 2015, 7:15 p.m.,

Re: Review Request 34268: stout library - adding support for Solaris

2015-05-22 Thread Stan Teresen
On May 19, 2015, 12:17 a.m., Till Toenshoff wrote: Thanks a lot for this, Stan - much appreciated! There are a couple of style nits here and there and one basic question on the need of the `read`-variant for Solaris. For submitting an updated patch, please consult the patch

Re: Review Request 34268: stout library - adding support for Solaris

2015-05-22 Thread Stan Teresen
On May 19, 2015, 12:17 a.m., Till Toenshoff wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp, line 72 https://reviews.apache.org/r/34268/diff/1/?file=961220#file961220line72 Could you please explain why the standard implementation of this function would not

Re: Review Request 34268: stout library - adding support for Solaris

2015-05-22 Thread Stan Teresen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34268/ --- (Updated May 22, 2015, 7:15 p.m.) Review request for mesos, Joris Van

Re: Review Request 34268: stout library - adding support for Solaris

2015-05-18 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34268/#review84202 --- Thanks a lot for this, Stan - much appreciated! There are a couple

Re: Review Request 34268: stout library - adding support for Solaris

2015-05-17 Thread Stan Teresen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34268/#review84068 --- Ship it! Ship It! - Stan Teresen On May 15, 2015, 2:25 p.m.,