On June 9, 2015, 6:25 p.m., Ben Mahler wrote:
src/tests/master_tests.cpp, lines 3031-3034
https://reviews.apache.org/r/34361/diff/3/?file=971359#file971359line3031
Why bother with all this? Why not just have `key1`, `value1`,
`key2`, `value2` inlined appropriately throughout
On June 10, 2015, 1:25 a.m., Ben Mahler wrote:
src/tests/master_tests.cpp, lines 3031-3034
https://reviews.apache.org/r/34361/diff/3/?file=971359#file971359line3031
Why bother with all this? Why not just have `key1`, `value1`,
`key2`, `value2` inlined appropriately throughout
On June 9, 2015, 6:25 p.m., Ben Mahler wrote:
src/tests/master_tests.cpp, lines 3031-3034
https://reviews.apache.org/r/34361/diff/3/?file=971359#file971359line3031
Why bother with all this? Why not just have `key1`, `value1`,
`key2`, `value2` inlined appropriately throughout
On June 9, 2015, 6:25 p.m., Ben Mahler wrote:
src/tests/master_tests.cpp, lines 3031-3034
https://reviews.apache.org/r/34361/diff/3/?file=971359#file971359line3031
Why bother with all this? Why not just have `key1`, `value1`,
`key2`, `value2` inlined appropriately throughout
On June 10, 2015, 1:25 a.m., Ben Mahler wrote:
src/tests/master_tests.cpp, lines 3031-3034
https://reviews.apache.org/r/34361/diff/3/?file=971359#file971359line3031
Why bother with all this? Why not just have `key1`, `value1`,
`key2`, `value2` inlined appropriately throughout
On June 9, 2015, 6:25 p.m., Ben Mahler wrote:
src/tests/master_tests.cpp, lines 3031-3034
https://reviews.apache.org/r/34361/diff/3/?file=971359#file971359line3031
Why bother with all this? Why not just have `key1`, `value1`,
`key2`, `value2` inlined appropriately throughout
On June 10, 2015, 1:25 a.m., Ben Mahler wrote:
src/tests/master_tests.cpp, lines 3031-3034
https://reviews.apache.org/r/34361/diff/3/?file=971359#file971359line3031
Why bother with all this? Why not just have `key1`, `value1`,
`key2`, `value2` inlined appropriately throughout
On June 9, 2015, 6:25 p.m., Ben Mahler wrote:
src/tests/master_tests.cpp, lines 3031-3034
https://reviews.apache.org/r/34361/diff/3/?file=971359#file971359line3031
Why bother with all this? Why not just have `key1`, `value1`,
`key2`, `value2` inlined appropriately throughout
On June 9, 2015, 6:19 p.m., Niklas Nielsen wrote:
Hey Colin!
Thanks for contributing this and I am sorry about the tardy turn-around
time.
The crux of the ticket was to consolidate the strings, so we only have to
maintain them one place.
With that in mind; instead of
On June 9, 2015, 6:19 p.m., Niklas Nielsen wrote:
Hey Colin!
Thanks for contributing this and I am sorry about the tardy turn-around
time.
The crux of the ticket was to consolidate the strings, so we only have to
maintain them one place.
With that in mind; instead of
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34361/
---
(Updated May 23, 2015, 8:02 p.m.)
Review request for mesos.
Changes
---
On May 20, 2015, 11:47 a.m., Alexander Rojas wrote:
src/examples/test_hook_module.cpp, lines 36-38
https://reviews.apache.org/r/34361/diff/1/?file=962951#file962951line36
This constants are used nowhere but in one method. Is there any reason
why they are not defined in the method
On May 20, 2015, 11:47 a.m., Alexander Rojas wrote:
This is a very good point, my original change had the values set as local
variables, but when I read through the task again it seemed like it was asking
for predefined constants. I'll make the changes and put them up during my
morning
On May 18, 2015, 5:48 p.m., Marco Massenzio wrote:
src/examples/test_hook_module.cpp, lines 36-38
https://reviews.apache.org/r/34361/diff/1/?file=962951#file962951line36
Thanks for doing this!
I'm wondering whether, as these are constants, shouldn't they be in
14 matches
Mail list logo