Re: Review Request 34431: Add htb queueing discipline
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34431/#review85400 --- Bad patch! Reviews applied: [34321, 34426] Failed command: ./support/apply-review.sh -n -r 34426 Error: 2015-05-27 18:07:59 URL:https://reviews.apache.org/r/34426/diff/raw/ [60225/60225] - 34426.patch [1] error: patch failed: src/linux/routing/queueing/fq_codel.cpp:64 error: src/linux/routing/queueing/fq_codel.cpp: patch does not apply error: patch failed: src/linux/routing/queueing/ingress.hpp:29 error: src/linux/routing/queueing/ingress.hpp: patch does not apply error: patch failed: src/linux/routing/queueing/ingress.cpp:63 error: src/linux/routing/queueing/ingress.cpp: patch does not apply error: patch failed: src/slave/containerizer/isolators/network/port_mapping.cpp:383 error: src/slave/containerizer/isolators/network/port_mapping.cpp: patch does not apply error: patch failed: src/tests/port_mapping_tests.cpp:1968 error: src/tests/port_mapping_tests.cpp: patch does not apply error: patch failed: src/tests/routing_tests.cpp:508 error: src/tests/routing_tests.cpp: patch does not apply Failed to apply patch - Mesos ReviewBot On May 22, 2015, 5:10 p.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34431/ --- (Updated May 22, 2015, 5:10 p.m.) Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang. Bugs: MESOS-2752 https://issues.apache.org/jira/browse/MESOS-2752 Repository: mesos Description --- Add htb queueing discipline Diffs - src/Makefile.am 34755cf795391c9b8051a5e4acc6caf844984496 src/linux/routing/queueing/htb.hpp PRE-CREATION src/linux/routing/queueing/htb.cpp PRE-CREATION Diff: https://reviews.apache.org/r/34431/diff/ Testing --- make check Thanks, Paul Brett
Re: Review Request 34431: Add htb queueing discipline
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34431/#review85273 --- src/linux/routing/queueing/htb.hpp https://reviews.apache.org/r/34431/#comment136818 s/interface/interface./ src/linux/routing/queueing/htb.cpp https://reviews.apache.org/r/34431/#comment136819 this seems strange? - Vinod Kone On May 22, 2015, 5:10 p.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34431/ --- (Updated May 22, 2015, 5:10 p.m.) Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang. Bugs: MESOS-2752 https://issues.apache.org/jira/browse/MESOS-2752 Repository: mesos Description --- Add htb queueing discipline Diffs - src/Makefile.am 34755cf795391c9b8051a5e4acc6caf844984496 src/linux/routing/queueing/htb.hpp PRE-CREATION src/linux/routing/queueing/htb.cpp PRE-CREATION Diff: https://reviews.apache.org/r/34431/diff/ Testing --- make check Thanks, Paul Brett
Re: Review Request 34431: Add htb queueing discipline
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34431/ --- (Updated May 22, 2015, 5:10 p.m.) Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang. Changes --- Updated to reflect changes to Handle Bugs: MESOS-2752 https://issues.apache.org/jira/browse/MESOS-2752 Repository: mesos Description --- Add htb queueing discipline Diffs (updated) - src/Makefile.am 34755cf795391c9b8051a5e4acc6caf844984496 src/linux/routing/queueing/htb.hpp PRE-CREATION src/linux/routing/queueing/htb.cpp PRE-CREATION Diff: https://reviews.apache.org/r/34431/diff/ Testing --- make check Thanks, Paul Brett
Re: Review Request 34431: Add htb queueing discipline
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34431/ --- (Updated May 21, 2015, 11:32 p.m.) Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang. Bugs: MESOS-2752 https://issues.apache.org/jira/browse/MESOS-2752 Repository: mesos Description --- Add htb queueing discipline Diffs - src/Makefile.am 34755cf795391c9b8051a5e4acc6caf844984496 src/linux/routing/queueing/htb.hpp PRE-CREATION src/linux/routing/queueing/htb.cpp PRE-CREATION Diff: https://reviews.apache.org/r/34431/diff/ Testing --- make check Thanks, Paul Brett
Re: Review Request 34431: Add htb queueing discipline
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34431/#review84523 --- Bad patch! Reviews applied: [34321, 34321] Failed command: ./support/apply-review.sh -n -r 34321 Error: 2015-05-20 16:14:05 URL:https://reviews.apache.org/r/34321/diff/raw/ [28663/28663] - 34321.patch [1] error: patch failed: src/linux/routing/filter/basic.hpp:30 error: src/linux/routing/filter/basic.hpp: patch does not apply error: patch failed: src/linux/routing/filter/basic.cpp:33 error: src/linux/routing/filter/basic.cpp: patch does not apply error: patch failed: src/linux/routing/filter/filter.hpp:29 error: src/linux/routing/filter/filter.hpp: patch does not apply error: patch failed: src/linux/routing/filter/handle.hpp:19 error: src/linux/routing/filter/handle.hpp: patch does not apply error: patch failed: src/linux/routing/filter/icmp.hpp:31 error: src/linux/routing/filter/icmp.hpp: patch does not apply error: patch failed: src/linux/routing/filter/icmp.cpp:37 error: src/linux/routing/filter/icmp.cpp: patch does not apply error: patch failed: src/linux/routing/filter/internal.hpp:58 error: src/linux/routing/filter/internal.hpp: patch does not apply error: patch failed: src/linux/routing/filter/ip.hpp:38 error: src/linux/routing/filter/ip.hpp: patch does not apply error: patch failed: src/linux/routing/filter/ip.cpp:33 error: src/linux/routing/filter/ip.cpp: patch does not apply error: src/linux/routing/handle.hpp: already exists in index error: patch failed: src/linux/routing/queueing/handle.hpp:19 error: src/linux/routing/queueing/handle.hpp: patch does not apply error: patch failed: src/tests/routing_tests.cpp:42 error: src/tests/routing_tests.cpp: patch does not apply Failed to apply patch - Mesos ReviewBot On May 20, 2015, 4:02 p.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34431/ --- (Updated May 20, 2015, 4:02 p.m.) Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang. Bugs: MESOS-2752 https://issues.apache.org/jira/browse/MESOS-2752 Repository: mesos Description --- Add htb queueing discipline Diffs - src/Makefile.am 34755cf795391c9b8051a5e4acc6caf844984496 src/linux/routing/queueing/htb.hpp PRE-CREATION src/linux/routing/queueing/htb.cpp PRE-CREATION Diff: https://reviews.apache.org/r/34431/diff/ Testing --- make check Thanks, Paul Brett
Re: Review Request 34431: Add htb queueing discipline
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34431/ --- (Updated May 20, 2015, 9:01 p.m.) Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang. Bugs: MESOS-2752 https://issues.apache.org/jira/browse/MESOS-2752 Repository: mesos Description --- Add htb queueing discipline Diffs (updated) - src/Makefile.am 34755cf795391c9b8051a5e4acc6caf844984496 src/linux/routing/queueing/htb.hpp PRE-CREATION src/linux/routing/queueing/htb.cpp PRE-CREATION Diff: https://reviews.apache.org/r/34431/diff/ Testing --- make check Thanks, Paul Brett
