Re: Review Request 34503: Updated post-reviews.py to auto set 'depends on' field.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34503/#review84626 --- Ship it! Ship It! - Jie Yu On May 20, 2015, 11:13 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34503/ --- (Updated May 20, 2015, 11:13 p.m.) Review request for mesos, Cody Maloney, Ian Downes, and Jie Yu. Repository: mesos Description --- Now contributors don't have to manually set the depends on field! Diffs - support/post-reviews.py 48497254ea5b60d8392d1e293268638764992fc1 Diff: https://reviews.apache.org/r/34503/diff/ Testing --- Tested with a chain of reviews. Thanks, Vinod Kone
Re: Review Request 34503: Updated post-reviews.py to auto set 'depends on' field.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34503/#review84608 --- support/post-reviews.py https://reviews.apache.org/r/34503/#comment135945 Not yours, but perhaps from subprocess import Popen? support/post-reviews.py https://reviews.apache.org/r/34503/#comment135947 unrelated, but where's this used? support/post-reviews.py https://reviews.apache.org/r/34503/#comment135948 What happens to parent_review_request_id here? support/post-reviews.py https://reviews.apache.org/r/34503/#comment135942 I presume this won't work if you choose to skip updating/creating some reviews? - Ian Downes On May 20, 2015, 3:50 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34503/ --- (Updated May 20, 2015, 3:50 p.m.) Review request for mesos, Cody Maloney, Ian Downes, and Jie Yu. Repository: mesos Description --- Now contributors don't have to manually set the depends on field! Diffs - support/post-reviews.py 48497254ea5b60d8392d1e293268638764992fc1 Diff: https://reviews.apache.org/r/34503/diff/ Testing --- Tested with a chain of reviews. Thanks, Vinod Kone
Re: Review Request 34503: Updated post-reviews.py to auto set 'depends on' field.
On May 20, 2015, 11 p.m., Ian Downes wrote: support/post-reviews.py, line 31 https://reviews.apache.org/r/34503/diff/1/?file=965856#file965856line31 Not yours, but perhaps from subprocess import Popen? and call, PIPE and STDOUT. On May 20, 2015, 11 p.m., Ian Downes wrote: support/post-reviews.py, line 33 https://reviews.apache.org/r/34503/diff/1/?file=965856#file965856line33 unrelated, but where's this used? dead code! deleted. On May 20, 2015, 11 p.m., Ian Downes wrote: support/post-reviews.py, lines 191-194 https://reviews.apache.org/r/34503/diff/1/?file=965856#file965856line191 What happens to parent_review_request_id here? good catch. fixed. - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34503/#review84608 --- On May 20, 2015, 10:50 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34503/ --- (Updated May 20, 2015, 10:50 p.m.) Review request for mesos, Cody Maloney, Ian Downes, and Jie Yu. Repository: mesos Description --- Now contributors don't have to manually set the depends on field! Diffs - support/post-reviews.py 48497254ea5b60d8392d1e293268638764992fc1 Diff: https://reviews.apache.org/r/34503/diff/ Testing --- Tested with a chain of reviews. Thanks, Vinod Kone
Re: Review Request 34503: Updated post-reviews.py to auto set 'depends on' field.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34503/ --- (Updated May 20, 2015, 11:13 p.m.) Review request for mesos, Cody Maloney, Ian Downes, and Jie Yu. Repository: mesos Description --- Now contributors don't have to manually set the depends on field! Diffs (updated) - support/post-reviews.py 48497254ea5b60d8392d1e293268638764992fc1 Diff: https://reviews.apache.org/r/34503/diff/ Testing --- Tested with a chain of reviews. Thanks, Vinod Kone
