Re: Review Request 34558: Move port mapping isolator configuration settings to file local scope for easier sharing.

2015-05-27 Thread Paul Brett

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34558/
---

(Updated May 27, 2015, 6:05 p.m.)


Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.


Bugs: MESOS-2332
https://issues.apache.org/jira/browse/MESOS-2332


Repository: mesos


Description
---

Move port mapping isolator configuration settings to file local scope for 
easier sharing.


Diffs
-

  src/tests/port_mapping_tests.cpp b8c2db6d0a02f79d38a21c227575299880980502 

Diff: https://reviews.apache.org/r/34558/diff/


Testing
---

make check


Thanks,

Paul Brett



Re: Review Request 34558: Move port mapping isolator configuration settings to file local scope for easier sharing.

2015-05-27 Thread Paul Brett

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34558/
---

(Updated May 27, 2015, 7:05 p.m.)


Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.


Changes
---

Incorporate feedback from Vinod


Bugs: MESOS-2332
https://issues.apache.org/jira/browse/MESOS-2332


Repository: mesos


Description
---

Move port mapping isolator configuration settings to file local scope for 
easier sharing.


Diffs (updated)
-

  src/tests/port_mapping_tests.cpp b8c2db6d0a02f79d38a21c227575299880980502 

Diff: https://reviews.apache.org/r/34558/diff/


Testing
---

make check


Thanks,

Paul Brett



Re: Review Request 34558: Move port mapping isolator configuration settings to file local scope for easier sharing.

2015-05-27 Thread Paul Brett

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34558/
---

(Updated May 27, 2015, 5:23 p.m.)


Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.


Changes
---

Rebase


Bugs: MESOS-2332
https://issues.apache.org/jira/browse/MESOS-2332


Repository: mesos


Description
---

Move port mapping isolator configuration settings to file local scope for 
easier sharing.


Diffs (updated)
-

  src/tests/port_mapping_tests.cpp b8c2db6d0a02f79d38a21c227575299880980502 

Diff: https://reviews.apache.org/r/34558/diff/


Testing
---

make check


Thanks,

Paul Brett



Re: Review Request 34558: Move port mapping isolator configuration settings to file local scope for easier sharing.

2015-05-27 Thread Vinod Kone

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34558/#review85435
---

Ship it!


Ship It!

- Vinod Kone


On May 27, 2015, 7:05 p.m., Paul Brett wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/34558/
 ---
 
 (Updated May 27, 2015, 7:05 p.m.)
 
 
 Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
 
 
 Bugs: MESOS-2332
 https://issues.apache.org/jira/browse/MESOS-2332
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Move port mapping isolator configuration settings to file local scope for 
 easier sharing.
 
 
 Diffs
 -
 
   src/tests/port_mapping_tests.cpp b8c2db6d0a02f79d38a21c227575299880980502 
 
 Diff: https://reviews.apache.org/r/34558/diff/
 
 
 Testing
 ---
 
 make check
 
 
 Thanks,
 
 Paul Brett
 




Re: Review Request 34558: Move port mapping isolator configuration settings to file local scope for easier sharing.

2015-05-27 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34558/#review85511
---


Patch looks great!

Reviews applied: [34558]

All tests passed.

- Mesos ReviewBot


On May 27, 2015, 7:05 p.m., Paul Brett wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/34558/
 ---
 
 (Updated May 27, 2015, 7:05 p.m.)
 
 
 Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
 
 
 Bugs: MESOS-2332
 https://issues.apache.org/jira/browse/MESOS-2332
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Move port mapping isolator configuration settings to file local scope for 
 easier sharing.
 
 
 Diffs
 -
 
   src/tests/port_mapping_tests.cpp b8c2db6d0a02f79d38a21c227575299880980502 
 
 Diff: https://reviews.apache.org/r/34558/diff/
 
 
 Testing
 ---
 
 make check
 
 
 Thanks,
 
 Paul Brett
 




Re: Review Request 34558: Move port mapping isolator configuration settings to file local scope for easier sharing.

2015-05-22 Thread Ian Downes

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34558/#review84881
---


bunch of grammatical stuff, much of it not actually yours but might as well 
clean it up while you're in this file.


src/tests/port_mapping_tests.cpp
https://reviews.apache.org/r/34558/#comment136309

any particular reason why? what about 1/1024/1024?



src/tests/port_mapping_tests.cpp
https://reviews.apache.org/r/34558/#comment136307

Don't include the ';' in these strings.



src/tests/port_mapping_tests.cpp
https://reviews.apache.org/r/34558/#comment136311

Below the start of ip_local_port_range?



src/tests/port_mapping_tests.cpp
https://reviews.apache.org/r/34558/#comment136312

What's the implication of a conflict? Does the test fail on conflict?



src/tests/port_mapping_tests.cpp
https://reviews.apache.org/r/34558/#comment136308

Ditto and elsewhere.



src/tests/port_mapping_tests.cpp
https://reviews.apache.org/r/34558/#comment136313

s/tracking/track/



src/tests/port_mapping_tests.cpp
https://reviews.apache.org/r/34558/#comment136314

s/persistant/persistent/
specifically, the persistentPorts range defined above.



src/tests/port_mapping_tests.cpp
https://reviews.apache.org/r/34558/#comment136315

s/defined/define/
s/container 1/container1/



src/tests/port_mapping_tests.cpp
https://reviews.apache.org/r/34558/#comment136316

s/ - /; /



src/tests/port_mapping_tests.cpp
https://reviews.apache.org/r/34558/#comment136317

s/connection/connecting/
can they even make a connection?



src/tests/port_mapping_tests.cpp
https://reviews.apache.org/r/34558/#comment136318

drop or pull this comment up



src/tests/port_mapping_tests.cpp
https://reviews.apache.org/r/34558/#comment136319

strings::join(;, {...})?



src/tests/port_mapping_tests.cpp
https://reviews.apache.org/r/34558/#comment136320

s/2/two/



src/tests/port_mapping_tests.cpp
https://reviews.apache.org/r/34558/#comment136321

sucessful in that data is written to the appropriate file?



src/tests/port_mapping_tests.cpp
https://reviews.apache.org/r/34558/#comment136322

s/get/receive/



src/tests/port_mapping_tests.cpp
https://reviews.apache.org/r/34558/#comment136324

s/a nc/an nc/ reads better, I think.
ditto elsewhere


- Ian Downes


On May 21, 2015, 4:31 p.m., Paul Brett wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/34558/
 ---
 
 (Updated May 21, 2015, 4:31 p.m.)
 
 
 Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
 
 
 Bugs: MESOS-2332
 https://issues.apache.org/jira/browse/MESOS-2332
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Move port mapping isolator configuration settings to file local scope for 
 easier sharing.
 
 
 Diffs
 -
 
   src/tests/port_mapping_tests.cpp b8c2db6d0a02f79d38a21c227575299880980502 
 
 Diff: https://reviews.apache.org/r/34558/diff/
 
 
 Testing
 ---
 
 make check
 
 
 Thanks,
 
 Paul Brett
 




Re: Review Request 34558: Move port mapping isolator configuration settings to file local scope for easier sharing.

2015-05-21 Thread Paul Brett

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34558/
---

(Updated May 21, 2015, 11:31 p.m.)


Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.


Bugs: MESOS-2332
https://issues.apache.org/jira/browse/MESOS-2332


Repository: mesos


Description
---

Move port mapping isolator configuration settings to file local scope for 
easier sharing.


Diffs
-

  src/tests/port_mapping_tests.cpp b8c2db6d0a02f79d38a21c227575299880980502 

Diff: https://reviews.apache.org/r/34558/diff/


Testing
---

make check


Thanks,

Paul Brett



Re: Review Request 34558: Move port mapping isolator configuration settings to file local scope for easier sharing.

2015-05-21 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34558/#review84766
---


Bad patch!

Reviews applied: [34321, 34426, 34321]

Failed command: ./support/apply-review.sh -n -r 34321

Error:
 2015-05-21 19:12:46 URL:https://reviews.apache.org/r/34321/diff/raw/ 
[28663/28663] - 34321.patch [1]
error: patch failed: src/linux/routing/filter/basic.hpp:30
error: src/linux/routing/filter/basic.hpp: patch does not apply
error: patch failed: src/linux/routing/filter/basic.cpp:33
error: src/linux/routing/filter/basic.cpp: patch does not apply
error: patch failed: src/linux/routing/filter/filter.hpp:29
error: src/linux/routing/filter/filter.hpp: patch does not apply
error: patch failed: src/linux/routing/filter/handle.hpp:19
error: src/linux/routing/filter/handle.hpp: patch does not apply
error: patch failed: src/linux/routing/filter/icmp.hpp:31
error: src/linux/routing/filter/icmp.hpp: patch does not apply
error: patch failed: src/linux/routing/filter/icmp.cpp:37
error: src/linux/routing/filter/icmp.cpp: patch does not apply
error: patch failed: src/linux/routing/filter/internal.hpp:58
error: src/linux/routing/filter/internal.hpp: patch does not apply
error: patch failed: src/linux/routing/filter/ip.hpp:38
error: src/linux/routing/filter/ip.hpp: patch does not apply
error: patch failed: src/linux/routing/filter/ip.cpp:33
error: src/linux/routing/filter/ip.cpp: patch does not apply
error: src/linux/routing/handle.hpp: already exists in index
error: patch failed: src/linux/routing/queueing/handle.hpp:19
error: src/linux/routing/queueing/handle.hpp: patch does not apply
error: patch failed: src/tests/routing_tests.cpp:42
error: src/tests/routing_tests.cpp: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On May 21, 2015, 6:48 p.m., Paul Brett wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/34558/
 ---
 
 (Updated May 21, 2015, 6:48 p.m.)
 
 
 Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
 
 
 Bugs: MESOS-2332
 https://issues.apache.org/jira/browse/MESOS-2332
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Move port mapping isolator configuration settings to file local scope for 
 easier sharing.
 
 
 Diffs
 -
 
   src/tests/port_mapping_tests.cpp b8c2db6d0a02f79d38a21c227575299880980502 
 
 Diff: https://reviews.apache.org/r/34558/diff/
 
 
 Testing
 ---
 
 make check
 
 
 Thanks,
 
 Paul Brett