Re: Review Request 34563: Allowed delegating constructors in styleguide.

2015-05-21 Thread Joerg Schad

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34563/
---

(Updated May 21, 2015, 8:55 p.m.)


Review request for mesos and Joris Van Remoortere.


Bugs: MESOS-2761
https://issues.apache.org/jira/browse/MESOS-2761


Repository: mesos


Description
---

Allowed delegating constructors in styleguide.


Diffs
-

  docs/mesos-c++-style-guide.md 13312f6f4fe1788791479bd768f60df0a8e80e69 

Diff: https://reviews.apache.org/r/34563/diff/


Testing
---


Thanks,

Joerg Schad



Re: Review Request 34563: Allowed delegating constructors in styleguide.

2015-05-21 Thread Joris Van Remoortere

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34563/#review84795
---

Ship it!


Ship It!

- Joris Van Remoortere


On May 21, 2015, 8:55 p.m., Joerg Schad wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/34563/
 ---
 
 (Updated May 21, 2015, 8:55 p.m.)
 
 
 Review request for mesos and Joris Van Remoortere.
 
 
 Bugs: MESOS-2761
 https://issues.apache.org/jira/browse/MESOS-2761
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Allowed delegating constructors in styleguide.
 
 
 Diffs
 -
 
   docs/mesos-c++-style-guide.md 13312f6f4fe1788791479bd768f60df0a8e80e69 
 
 Diff: https://reviews.apache.org/r/34563/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Joerg Schad
 




Re: Review Request 34563: Allowed delegating constructors in styleguide.

2015-05-21 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34563/#review84815
---


Patch looks great!

Reviews applied: [34563]

All tests passed.

- Mesos ReviewBot


On May 21, 2015, 8:55 p.m., Joerg Schad wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/34563/
 ---
 
 (Updated May 21, 2015, 8:55 p.m.)
 
 
 Review request for mesos and Joris Van Remoortere.
 
 
 Bugs: MESOS-2761
 https://issues.apache.org/jira/browse/MESOS-2761
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Allowed delegating constructors in styleguide.
 
 
 Diffs
 -
 
   docs/mesos-c++-style-guide.md 13312f6f4fe1788791479bd768f60df0a8e80e69 
 
 Diff: https://reviews.apache.org/r/34563/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Joerg Schad