Re: Review Request 34614: Added 'updateSlave()' API call to Allocator.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34614/ --- (Updated May 22, 2015, 9:42 p.m.) Review request for mesos, Jie Yu and Niklas Nielsen. Changes --- added 'depends' on. Bugs: MESOS-2730 https://issues.apache.org/jira/browse/MESOS-2730 Repository: mesos Description --- Just the stub API. Implementation is in the subsequent review. Diffs - include/mesos/master/allocator.hpp 0328ae4b2a6b39cefff3e64136f209f1593808cd src/master/allocator/mesos/allocator.hpp e6f611435969730baedf55ca475e5fa18d700b64 src/master/allocator/mesos/hierarchical.hpp 4b36d42b0c4614493562e57c5eac90c6c38ca087 src/tests/mesos.hpp 924b0ff7d307ce9650b78d1c698082c0cf4bb56c Diff: https://reviews.apache.org/r/34614/diff/ Testing --- make check Thanks, Vinod Kone
Re: Review Request 34614: Added 'updateSlave()' API call to Allocator.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34614/ --- (Updated May 22, 2015, 9:40 p.m.) Review request for mesos, Jie Yu and Niklas Nielsen. Bugs: MESOS-2730 https://issues.apache.org/jira/browse/MESOS-2730 Repository: mesos Description (updated) --- Just the stub API. Implementation is in the subsequent review. Diffs - include/mesos/master/allocator.hpp 0328ae4b2a6b39cefff3e64136f209f1593808cd src/master/allocator/mesos/allocator.hpp e6f611435969730baedf55ca475e5fa18d700b64 src/master/allocator/mesos/hierarchical.hpp 4b36d42b0c4614493562e57c5eac90c6c38ca087 src/tests/mesos.hpp 924b0ff7d307ce9650b78d1c698082c0cf4bb56c Diff: https://reviews.apache.org/r/34614/diff/ Testing --- make check Thanks, Vinod Kone
Re: Review Request 34614: Added 'updateSlave()' API call to Allocator.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34614/#review85029 --- Ship it! include/mesos/master/allocator.hpp https://reviews.apache.org/r/34614/#comment136503 Could you please add a TODO here saying that we will eventually replace 'oversubscribed' here with 'total' so that we can use this interface to update slave's regular total as well. - Jie Yu On May 22, 2015, 9:42 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34614/ --- (Updated May 22, 2015, 9:42 p.m.) Review request for mesos, Jie Yu and Niklas Nielsen. Bugs: MESOS-2730 https://issues.apache.org/jira/browse/MESOS-2730 Repository: mesos Description --- Just the stub API. Implementation is in the subsequent review. Diffs - include/mesos/master/allocator.hpp 0328ae4b2a6b39cefff3e64136f209f1593808cd src/master/allocator/mesos/allocator.hpp e6f611435969730baedf55ca475e5fa18d700b64 src/master/allocator/mesos/hierarchical.hpp 4b36d42b0c4614493562e57c5eac90c6c38ca087 src/tests/mesos.hpp 924b0ff7d307ce9650b78d1c698082c0cf4bb56c Diff: https://reviews.apache.org/r/34614/diff/ Testing --- make check Thanks, Vinod Kone
