Re: Review Request 34645: Update existing lambdas to meet style guide

2015-06-09 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34645/#review87149 --- Ship it! Ship It! - Benjamin Hindman On June 1, 2015, 5:26 p.m.,

Re: Review Request 34645: Update existing lambdas to meet style guide

2015-06-09 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34645/#review87147 --- Ship it! I'll get this and your other patch committed with BenH. Th

Re: Review Request 34645: Update existing lambdas to meet style guide

2015-06-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34645/#review86056 --- Patch looks great! Reviews applied: [34644, 34645] All tests passe

Re: Review Request 34645: Update existing lambdas to meet style guide

2015-06-01 Thread haosdent huang
> On May 25, 2015, 11:05 p.m., Joris Van Remoortere wrote: > > This is an interesting case. We have a proxy to another function, rather > > than the implementation of that function as a lambda. > > I'm curious what the community's view is on using the proxy lambda approach > > as per your patch

Re: Review Request 34645: Update existing lambdas to meet style guide

2015-06-01 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34645/ --- (Updated June 1, 2015, 5:26 p.m.) Review request for mesos, Benjamin Hindman an

Re: Review Request 34645: Update existing lambdas to meet style guide

2015-06-01 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34645/ --- (Updated June 1, 2015, 5:24 p.m.) Review request for mesos, Benjamin Hindman an

Re: Review Request 34645: Update existing lambdas to meet style guide

2015-05-29 Thread haosdent huang
> On May 25, 2015, 11:05 p.m., Joris Van Remoortere wrote: > > This is an interesting case. We have a proxy to another function, rather > > than the implementation of that function as a lambda. > > I'm curious what the community's view is on using the proxy lambda approach > > as per your patch

Re: Review Request 34645: Update existing lambdas to meet style guide

2015-05-26 Thread Joris Van Remoortere
> On May 25, 2015, 11:05 p.m., Joris Van Remoortere wrote: > > This is an interesting case. We have a proxy to another function, rather > > than the implementation of that function as a lambda. > > I'm curious what the community's view is on using the proxy lambda approach > > as per your patch

Re: Review Request 34645: Update existing lambdas to meet style guide

2015-05-26 Thread haosdent huang
> On May 25, 2015, 11:05 p.m., Joris Van Remoortere wrote: > > This is an interesting case. We have a proxy to another function, rather > > than the implementation of that function as a lambda. > > I'm curious what the community's view is on using the proxy lambda approach > > as per your patch

Re: Review Request 34645: Update existing lambdas to meet style guide

2015-05-25 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34645/#review85137 --- This is an interesting case. We have a proxy to another function, ra