Re: Review Request 34662: Modularized ResourceEstimator and added test for that module

2015-05-25 Thread Bartek Plotka
> On May 26, 2015, 4:16 a.m., Szymon Konefal wrote: > > src/tests/oversubscription_tests.cpp, line 80 > > > > > > Why CHECK_SOME rather than ASSERT_SOME? > > CHECK_SOME prints only a log, and ASSERT_SOME could retur

Re: Review Request 34662: Modularized ResourceEstimator and added test for that module

2015-05-25 Thread Bartek Plotka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34662/ --- (Updated May 26, 2015, 4:36 a.m.) Review request for mesos, Jie Yu, Niklas Niel

Re: Review Request 34662: Modularized ResourceEstimator and added test for that module

2015-05-25 Thread Szymon Konefal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34662/#review85146 --- src/tests/oversubscription_tests.cpp