Re: Review Request 34669: Add a virtualenv bootstrapper for post-reviews.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34669/#review141454
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On May 26, 2015, 5:30 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34669/
> ---
> 
> (Updated May 26, 2015, 5:30 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add a virtualenv bootstrapper for post-reviews to make it easier to post 
> reviews.  More or less cargo-culted from 
> https://github.com/apache/aurora/blob/master/build-support/virtualenv and 
> https://github.com/apache/aurora/blob/master/rbt
> 
> 
> Diffs
> -
> 
>   .gitignore-template 934cad71a370d5c64d9a0994f775f39db74f5851 
>   support/post-reviews.sh PRE-CREATION 
>   support/virtualenv.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/34669/diff/
> 
> 
> Testing
> ---
> 
> Posted this review using support/post-reviews.sh.
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 34669: Add a virtualenv bootstrapper for post-reviews.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34669/#review85327
---


Patch looks great!

Reviews applied: [34669]

All tests passed.

- Mesos ReviewBot


On May 26, 2015, 5:30 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34669/
> ---
> 
> (Updated May 26, 2015, 5:30 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add a virtualenv bootstrapper for post-reviews to make it easier to post 
> reviews.  More or less cargo-culted from 
> https://github.com/apache/aurora/blob/master/build-support/virtualenv and 
> https://github.com/apache/aurora/blob/master/rbt
> 
> 
> Diffs
> -
> 
>   .gitignore-template 934cad71a370d5c64d9a0994f775f39db74f5851 
>   support/post-reviews.sh PRE-CREATION 
>   support/virtualenv.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/34669/diff/
> 
> 
> Testing
> ---
> 
> Posted this review using support/post-reviews.sh.
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 34669: Add a virtualenv bootstrapper for post-reviews.

[Brian Wickman]

> On May 26, 2015, 9:16 p.m., Vinod Kone wrote:
> > support/virtualenv.sh, line 20
> > 
> >
> > I'm curios. What part of this workflow necessitates a python2.7?

Nothing other than saving yourself the shame of running an ancient python 
interpreter (2.7 is pretty ancient too, but I don't think that Python 3.x is 
explicitly supported by RBTools yet.)


- Brian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34669/#review85261
---


On May 26, 2015, 5:30 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34669/
> ---
> 
> (Updated May 26, 2015, 5:30 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add a virtualenv bootstrapper for post-reviews to make it easier to post 
> reviews.  More or less cargo-culted from 
> https://github.com/apache/aurora/blob/master/build-support/virtualenv and 
> https://github.com/apache/aurora/blob/master/rbt
> 
> 
> Diffs
> -
> 
>   .gitignore-template 934cad71a370d5c64d9a0994f775f39db74f5851 
>   support/post-reviews.sh PRE-CREATION 
>   support/virtualenv.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/34669/diff/
> 
> 
> Testing
> ---
> 
> Posted this review using support/post-reviews.sh.
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>

Re: Review Request 34669: Add a virtualenv bootstrapper for post-reviews.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34669/#review85261
---



support/virtualenv.sh


I'm curios. What part of this workflow necessitates a python2.7?


- Vinod Kone


On May 26, 2015, 5:30 p.m., Brian Wickman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34669/
> ---
> 
> (Updated May 26, 2015, 5:30 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add a virtualenv bootstrapper for post-reviews to make it easier to post 
> reviews.  More or less cargo-culted from 
> https://github.com/apache/aurora/blob/master/build-support/virtualenv and 
> https://github.com/apache/aurora/blob/master/rbt
> 
> 
> Diffs
> -
> 
>   .gitignore-template 934cad71a370d5c64d9a0994f775f39db74f5851 
>   support/post-reviews.sh PRE-CREATION 
>   support/virtualenv.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/34669/diff/
> 
> 
> Testing
> ---
> 
> Posted this review using support/post-reviews.sh.
> 
> 
> Thanks,
> 
> Brian Wickman
> 
>