Re: Review Request 34830: Fix routing ingress/fq_codel search returning wrong qdisc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34830/ --- (Updated June 2, 2015, 12:23 a.m.) Review request for mesos, Chi Zhang, Ian Dow

Re: Review Request 34830: Fix routing ingress/fq_codel search returning wrong qdisc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34830/ --- (Updated June 1, 2015, 8:40 p.m.) Review request for mesos, Chi Zhang, Ian Down

Re: Review Request 34830: Fix routing ingress/fq_codel search returning wrong qdisc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34830/#review86060 --- src/linux/routing/queueing/fq_codel.hpp

Re: Review Request 34830: Fix routing ingress/fq_codel search returning wrong qdisc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34830/ --- (Updated June 1, 2015, 7:49 p.m.) Review request for mesos, Chi Zhang, Ian Down

Re: Review Request 34830: Fix routing ingress/fq_codel search returning wrong qdisc.

> On June 1, 2015, 6:33 p.m., Jie Yu wrote: > > src/linux/routing/queueing/internal.hpp, line 207 > > > > > > OK, this is confusing to me. We return false in the following two cases: > > > > 1) link does not e

Re: Review Request 34830: Fix routing ingress/fq_codel search returning wrong qdisc.

> On June 1, 2015, 5:59 p.m., Chi Zhang wrote: > > src/linux/routing/queueing/fq_codel.cpp, line 102 > > > > > > ignore if you have done in a different patch: > > > > egress::ROOT? (You had ingress::ROOT) > >

Re: Review Request 34830: Fix routing ingress/fq_codel search returning wrong qdisc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34830/#review86029 --- src/linux/routing/queueing/fq_codel.cpp

Re: Review Request 34830: Fix routing ingress/fq_codel search returning wrong qdisc.

> On June 1, 2015, 5:59 p.m., Chi Zhang wrote: > > src/linux/routing/queueing/ingress.hpp, lines 55-56 > > > > > > a bit confused by "an ingress qdisc on the egress side of the link" > > > > I saw this in other

Re: Review Request 34830: Fix routing ingress/fq_codel search returning wrong qdisc.

> On June 1, 2015, 5:59 p.m., Chi Zhang wrote: > > src/linux/routing/queueing/ingress.cpp, lines 44-51 > > > > > > Two blank lines between the functions. > > > > here and other places. Since the functions are

Re: Review Request 34830: Fix routing ingress/fq_codel search returning wrong qdisc.

> On June 1, 2015, 5:59 p.m., Chi Zhang wrote: > > src/linux/routing/queueing/internal.hpp, lines 128-131 > > > > > > reinterpret_cast is the preferred c++ way, but I am not sure if the > > codebase has done similiar

Re: Review Request 34830: Fix routing ingress/fq_codel search returning wrong qdisc.

> On June 1, 2015, 5:59 p.m., Chi Zhang wrote: > > src/linux/routing/queueing/fq_codel.cpp, line 102 > > > > > > ignore if you have done in a different patch: > > > > egress::ROOT? (You had ingress::ROOT) fee

Re: Review Request 34830: Fix routing ingress/fq_codel search returning wrong qdisc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34830/#review86006 --- src/linux/routing/queueing/fq_codel.cpp

Re: Review Request 34830: Fix routing ingress/fq_codel search returning wrong qdisc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34830/ --- (Updated May 30, 2015, 9 p.m.) Review request for mesos, Chi Zhang, Ian Downes,

Re: Review Request 34830: Fix routing ingress/fq_codel search returning wrong qdisc.

> On May 30, 2015, 6:12 p.m., Isabel Jimenez wrote: > > src/linux/routing/queueing/internal.hpp, line 128 > > > > > > Why use reinterpret_cast here? am I missing something that needs > > changing the bit interpretatio

Re: Review Request 34830: Fix routing ingress/fq_codel search returning wrong qdisc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34830/#review85828 --- Ship it! src/linux/routing/queueing/fq_codel.hpp