Re: Review Request 34887: MESOS-2788: Fixed the statistics got by cmd *mesos ps* and webUI is mis-matching

2015-06-01 Thread haosdent huang 


> On June 1, 2015, 1:33 p.m., haosdent huang wrote:
> > src/cli/mesos-ps, line 105
> > 
> >
> > How about add `bytes = float(bytes)` at the beginning. And don't need 
> > change `1024` to `1024.0` at below code.
> 
> weitao zhou wrote:
> Both are okay from me, or I can't figure out any better solution. here I 
> pushed another patch https://reviews.apache.org/r/34921/ based on your 
> comment. Review or ship it as you guys' opinion. Python3 has handled it.

Because this patch is submmitted, you could ignore it. I think change 1024 to 
1024.0 is also OK. :-)


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34887/#review85978
---


On June 1, 2015, 12:15 p.m., weitao zhou wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34887/
> ---
> 
> (Updated June 1, 2015, 12:15 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-2788
> https://issues.apache.org/jira/browse/MESOS-2788
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> mesos-ps is dropping fractional part in statistics about Mem Allocated if the 
> real Mem Allocated is greater than 1G
> 
> 
> Diffs
> -
> 
>   src/cli/mesos-ps ddd9ec5dd0045d168ee4ed840194fe18c304b56a 
> 
> Diff: https://reviews.apache.org/r/34887/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> weitao zhou
> 
>

Re: Review Request 34887: MESOS-2788: Fixed the statistics got by cmd *mesos ps* and webUI is mis-matching

2015-06-01 Thread weitao zhou 


> On 六月 1, 2015, 1:33 p.m., haosdent huang wrote:
> > src/cli/mesos-ps, line 105
> > 
> >
> > How about add `bytes = float(bytes)` at the beginning. And don't need 
> > change `1024` to `1024.0` at below code.

Both are okay from me, or I can't figure out any better solution. here I pushed 
another patch https://reviews.apache.org/r/34921/ based on your comment. Review 
or ship it as you guys' opinion. Python3 has handled it.


- weitao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34887/#review85978
---


On 六月 1, 2015, 12:15 p.m., weitao zhou wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34887/
> ---
> 
> (Updated 六月 1, 2015, 12:15 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-2788
> https://issues.apache.org/jira/browse/MESOS-2788
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> mesos-ps is dropping fractional part in statistics about Mem Allocated if the 
> real Mem Allocated is greater than 1G
> 
> 
> Diffs
> -
> 
>   src/cli/mesos-ps ddd9ec5dd0045d168ee4ed840194fe18c304b56a 
> 
> Diff: https://reviews.apache.org/r/34887/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> weitao zhou
> 
>

Re: Review Request 34887: MESOS-2788: Fixed the statistics got by cmd *mesos ps* and webUI is mis-matching

2015-06-01 Thread Ben Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34887/#review86037
---

Ship it!


Ship It!

- Ben Mahler


On June 1, 2015, 12:15 p.m., weitao zhou wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34887/
> ---
> 
> (Updated June 1, 2015, 12:15 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-2788
> https://issues.apache.org/jira/browse/MESOS-2788
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> mesos-ps is dropping fractional part in statistics about Mem Allocated if the 
> real Mem Allocated is greater than 1G
> 
> 
> Diffs
> -
> 
>   src/cli/mesos-ps ddd9ec5dd0045d168ee4ed840194fe18c304b56a 
> 
> Diff: https://reviews.apache.org/r/34887/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> weitao zhou
> 
>

Re: Review Request 34887: MESOS-2788: Fixed the statistics got by cmd *mesos ps* and webUI is mis-matching

2015-06-01 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34887/#review85979
---

Ship it!


Ship It!

- haosdent huang


On June 1, 2015, 12:15 p.m., weitao zhou wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34887/
> ---
> 
> (Updated June 1, 2015, 12:15 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-2788
> https://issues.apache.org/jira/browse/MESOS-2788
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> mesos-ps is dropping fractional part in statistics about Mem Allocated if the 
> real Mem Allocated is greater than 1G
> 
> 
> Diffs
> -
> 
>   src/cli/mesos-ps ddd9ec5dd0045d168ee4ed840194fe18c304b56a 
> 
> Diff: https://reviews.apache.org/r/34887/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> weitao zhou
> 
>

Re: Review Request 34887: MESOS-2788: Fixed the statistics got by cmd *mesos ps* and webUI is mis-matching

2015-06-01 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34887/#review85978
---



src/cli/mesos-ps


How about add `bytes = float(bytes)` at the beginning. And don't need 
change `1024` to `1024.0` at below code.


- haosdent huang


On June 1, 2015, 12:15 p.m., weitao zhou wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34887/
> ---
> 
> (Updated June 1, 2015, 12:15 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-2788
> https://issues.apache.org/jira/browse/MESOS-2788
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> mesos-ps is dropping fractional part in statistics about Mem Allocated if the 
> real Mem Allocated is greater than 1G
> 
> 
> Diffs
> -
> 
>   src/cli/mesos-ps ddd9ec5dd0045d168ee4ed840194fe18c304b56a 
> 
> Diff: https://reviews.apache.org/r/34887/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> weitao zhou
> 
>

Re: Review Request 34887: MESOS-2788: Fixed the statistics got by cmd *mesos ps* and webUI is mis-matching

2015-06-01 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34887/#review85970
---


Patch looks great!

Reviews applied: [34887]

All tests passed.

- Mesos ReviewBot


On June 1, 2015, 12:15 p.m., weitao zhou wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34887/
> ---
> 
> (Updated June 1, 2015, 12:15 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-2788
> https://issues.apache.org/jira/browse/MESOS-2788
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> mesos-ps is dropping fractional part in statistics about Mem Allocated if the 
> real Mem Allocated is greater than 1G
> 
> 
> Diffs
> -
> 
>   src/cli/mesos-ps ddd9ec5dd0045d168ee4ed840194fe18c304b56a 
> 
> Diff: https://reviews.apache.org/r/34887/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> weitao zhou
> 
>

Re: Review Request 34887: MESOS-2788: Fixed the statistics got by cmd *mesos ps* and webUI is mis-matching

2015-06-01 Thread weitao zhou 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34887/
---

(Updated 六月 1, 2015, 12:15 p.m.)


Review request for mesos.


Bugs: MESOS-2788
https://issues.apache.org/jira/browse/MESOS-2788


Repository: mesos


Description
---

mesos-ps is dropping fractional part in statistics about Mem Allocated if the 
real Mem Allocated is greater than 1G


Diffs
-

  src/cli/mesos-ps ddd9ec5dd0045d168ee4ed840194fe18c304b56a 

Diff: https://reviews.apache.org/r/34887/diff/


Testing
---


Thanks,

weitao zhou