----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34968/#review86341 -----------------------------------------------------------
Ship it! Ship It! - Vinod Kone On June 3, 2015, 1:07 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34968/ > ----------------------------------------------------------- > > (Updated June 3, 2015, 1:07 a.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos > > > Description > ------- > > Discovered this while writing an example framework that uses metrics. > > > Diffs > ----- > > 3rdparty/libprocess/src/metrics/metrics.cpp > 38905d3e920288ac8c18ebed2743ebac9f438d2e > > Diff: https://reviews.apache.org/r/34968/diff/ > > > Testing > ------- > > This fixed the deadlock here: > > ``` > Thread 1 (Thread 0x7f421282f770 (LWP 9942)): > #0 0x00007f420d625019 in pthread_cond_wait@@GLIBC_2.3.2 () from > /lib64/libpthread.so.0 > #1 0x00007f42104023e7 in once () from > /home/bmahler/git/mesos/build/src/.libs/libmesos-0.23.0.so > #2 0x00007f4210f17fb1 in instance () from > /home/bmahler/git/mesos/build/src/.libs/libmesos-0.23.0.so > #3 0x00007f4210f4be51 in initialize () from > /home/bmahler/git/mesos/build/src/.libs/libmesos-0.23.0.so > #4 0x00007f4210f58014 in ProcessBase () from > /home/bmahler/git/mesos/build/src/.libs/libmesos-0.23.0.so > #5 0x00007f4210f1a289 in MetricsProcess () from > /home/bmahler/git/mesos/build/src/.libs/libmesos-0.23.0.so > #6 0x00007f4210f17fcd in instance () from > /home/bmahler/git/mesos/build/src/.libs/libmesos-0.23.0.so > #7 0x000000000048cc94 in add<process::metrics::Counter> () > #8 0x000000000048821c in Metrics () > #9 0x0000000000486c07 in OversubscribingScheduler () > #10 0x000000000047f06a in main () > ``` > > > Thanks, > > Ben Mahler > >
