Re: Review Request 34980: Pass callback to the resource estimator to retrieve ResourceUsage from resource monitor on demand.

2015-06-03 Thread Bartek Plotka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34980/ --- (Updated June 3, 2015, 9:16 p.m.) Review request for mesos, Jie Yu, Niklas

Re: Review Request 34980: Pass callback to the resource estimator to retrieve ResourceUsage from resource monitor on demand.

2015-06-03 Thread Bartek Plotka
On June 3, 2015, 9:06 p.m., Niklas Nielsen wrote: Do you want to add a test to verify that this works? :) Definitely will do that in next patch (: - Bartek --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 34980: Pass callback to the resource estimator to retrieve ResourceUsage from resource monitor on demand.

2015-06-03 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34980/#review86497 --- src/slave/resource_estimators/noop.cpp

Re: Review Request 34980: Pass callback to the resource estimator to retrieve ResourceUsage from resource monitor on demand.

2015-06-03 Thread Bartek Plotka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34980/ --- (Updated June 4, 2015, 12:08 a.m.) Review request for mesos, Jie Yu, Niklas

Re: Review Request 34980: Pass callback to the resource estimator to retrieve ResourceUsage from resource monitor on demand.

2015-06-03 Thread Bartek Plotka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34980/ --- (Updated June 3, 2015, 10:21 p.m.) Review request for mesos, Jie Yu, Niklas

Re: Review Request 34980: Pass callback to the resource estimator to retrieve ResourceUsage from resource monitor on demand.

2015-06-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34980/#review86366 --- Patch looks great! Reviews applied: [34962, 34980] All tests

Re: Review Request 34980: Pass callback to the resource estimator to retrieve ResourceUsage from resource monitor on demand.

2015-06-03 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34980/#review86441 --- src/slave/slave.cpp

Re: Review Request 34980: Pass callback to the resource estimator to retrieve ResourceUsage from resource monitor on demand.

2015-06-02 Thread Bartek Plotka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34980/#review86362 --- Any idea why review requests failed to show diff of noop.hpp? I

Re: Review Request 34980: Pass callback to the resource estimator to retrieve ResourceUsage from resource monitor on demand.

2015-06-02 Thread Bartek Plotka
On June 3, 2015, 5:58 a.m., Bartek Plotka wrote: Any idea why review requests failed to show diff of noop.hpp? I guess it something with https://reviews.apache.org/r/34962/diff/#file976910, since this patch depends on that. reviewboard* - Bartek