Re: Review Request 35037: Added doxygen link to home.md.

[Niklas Nielsen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35037/
---

(Updated June 8, 2015, 4:41 p.m.)


Review request for mesos and Ben Mahler.


Changes
---

Addressed Ben's comments


Repository: mesos


Description
---

Added doxygen link to home.md.


Diffs (updated)
-

  docs/home.md f2d3e32ca8a1b2735849242daaaf1a6201ce2684 

Diff: https://reviews.apache.org/r/35037/diff/


Testing
---


Thanks,

Niklas Nielsen

Re: Review Request 35037: Added doxygen link to home.md.

[Niklas Nielsen]

> On June 3, 2015, 4:37 p.m., Ben Mahler wrote:
> > docs/home.md, line 36
> > 
> >
> > Should this be linking to the framework part of the C++ API? For 
> > example: http://mesos.apache.org/api/latest/c++/namespacemesos.html
> > That way, we don't have to say "internal C++ API" in the framework 
> > development section, which seems a bit odd?
> > 
> > Also, can we have the top-level link you have here in the 'contributing 
> > to mesos' section?

Great suggestions! Will get that in.


- Niklas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35037/#review86510
---


On June 3, 2015, 4 p.m., Niklas Nielsen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35037/
> ---
> 
> (Updated June 3, 2015, 4 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added doxygen link to home.md.
> 
> 
> Diffs
> -
> 
>   docs/home.md f2d3e32ca8a1b2735849242daaaf1a6201ce2684 
> 
> Diff: https://reviews.apache.org/r/35037/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>

Re: Review Request 35037: Added doxygen link to home.md.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35037/#review86542
---


Patch looks great!

Reviews applied: [35037]

All tests passed.

- Mesos ReviewBot


On June 3, 2015, 11 p.m., Niklas Nielsen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35037/
> ---
> 
> (Updated June 3, 2015, 11 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added doxygen link to home.md.
> 
> 
> Diffs
> -
> 
>   docs/home.md f2d3e32ca8a1b2735849242daaaf1a6201ce2684 
> 
> Diff: https://reviews.apache.org/r/35037/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>

Re: Review Request 35037: Added doxygen link to home.md.

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35037/#review86510
---

Ship it!


Thanks Nik!


docs/home.md


Should this be linking to the framework part of the C++ API? For example: 
http://mesos.apache.org/api/latest/c++/namespacemesos.html
That way, we don't have to say "internal C++ API" in the framework 
development section, which seems a bit odd?

Also, can we have the top-level link you have here in the 'contributing to 
mesos' section?


- Ben Mahler


On June 3, 2015, 11 p.m., Niklas Nielsen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35037/
> ---
> 
> (Updated June 3, 2015, 11 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added doxygen link to home.md.
> 
> 
> Diffs
> -
> 
>   docs/home.md f2d3e32ca8a1b2735849242daaaf1a6201ce2684 
> 
> Diff: https://reviews.apache.org/r/35037/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>