Re: Review Request 35157: Added unit tests for fetching ResoruceUsage in both QoS Controller and Resource Estimator .

2015-06-05 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35157/#review86882
---


Patch looks great!

Reviews applied: [35164, 35157]

All tests passed.

- Mesos ReviewBot


On June 5, 2015, 11:53 p.m., Bartek Plotka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35157/
> ---
> 
> (Updated June 5, 2015, 11:53 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Jie Yu, Niklas Nielsen, Szymon Konefal, 
> and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added tests for QoS Controller and ResourceEstimator fetching ResoruceUsage 
> from ResourceMonitor.
> 
> This is the unit test for https://reviews.apache.org/r/34980/ and 
> https://reviews.apache.org/r/35164/
> 
> 
> Diffs
> -
> 
>   src/tests/mesos.hpp 087953d6bc716f11c315a0736f06f712d7f69417 
>   src/tests/mesos.cpp dff45b0d3bf9ef53f19575ab3d90a0b223755d6a 
>   src/tests/oversubscription_tests.cpp 
> afd7ff4f2b50cb20cc2c8865b655ad1f8eb0c8b7 
> 
> Diff: https://reviews.apache.org/r/35157/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Bartek Plotka
> 
>

Re: Review Request 35157: Added unit tests for fetching ResoruceUsage in both QoS Controller and Resource Estimator .

2015-06-05 Thread Bartek Plotka 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35157/
---

(Updated June 5, 2015, 11:53 p.m.)


Review request for mesos, Ben Mahler, Jie Yu, Niklas Nielsen, Szymon Konefal, 
and Vinod Kone.


Changes
---

Added QoS Controller test.


Summary (updated)
-

Added unit tests for fetching ResoruceUsage in both QoS Controller and Resource 
Estimator .


Repository: mesos


Description (updated)
---

Added tests for QoS Controller and ResourceEstimator fetching ResoruceUsage 
from ResourceMonitor.

This is the unit test for https://reviews.apache.org/r/34980/ and 
https://reviews.apache.org/r/35164/


Diffs (updated)
-

  src/tests/mesos.hpp 087953d6bc716f11c315a0736f06f712d7f69417 
  src/tests/mesos.cpp dff45b0d3bf9ef53f19575ab3d90a0b223755d6a 
  src/tests/oversubscription_tests.cpp afd7ff4f2b50cb20cc2c8865b655ad1f8eb0c8b7 

Diff: https://reviews.apache.org/r/35157/diff/


Testing
---

make check


Thanks,

Bartek Plotka