Vinod,
I am working on it. I reckon this will work:
s/Return()/DeclineOffers()
I’ll prepare a RR with this, that also fixes the CHECK the way Jie proposed.
Bernd
On Jun 12, 2015, at 8:59 PM, Vinod Kone vinodk...@gmail.com wrote:
This is an automatically generated e-mail. To reply,
On June 9, 2015, 6:11 p.m., Vinod Kone wrote:
src/tests/fetcher_cache_tests.cpp, lines 201-207
https://reviews.apache.org/r/35247/diff/1/?file=981340#file981340line201
While this looks good as a temporary fix, what is the long term
strategy here?
I really don't like
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35247/#review87616
---
I'll commit this for now with the reordering fix. Please follow up
On June 9, 2015, 6:11 p.m., Vinod Kone wrote:
src/tests/fetcher_cache_tests.cpp, lines 201-207
https://reviews.apache.org/r/35247/diff/1/?file=981340#file981340line201
While this looks good as a temporary fix, what is the long term
strategy here?
I really don't like
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35247/
---
(Updated June 9, 2015, 2:32 a.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35247/#review87157
---
Patch looks great!
Reviews applied: [35247]
All tests passed.
-
On June 9, 2015, 11:11 a.m., Vinod Kone wrote:
src/tests/fetcher_cache_tests.cpp, lines 360-361
https://reviews.apache.org/r/35247/diff/1/?file=981340#file981340line360
Why not just do AWAIT_READY(offers)?
That does not compile here, because it contains a return of type void and
On June 9, 2015, 11:11 a.m., Vinod Kone wrote:
src/tests/fetcher_cache_tests.cpp, lines 201-207
https://reviews.apache.org/r/35247/diff/1/?file=981340#file981340line201
While this looks good as a temporary fix, what is the long term
strategy here?
I really don't like
