Re: Review Request 35270: make a bunch of JSONP callback URLs in mesos UI protocol-relative
> On June 9, 2015, 11:49 p.m., Vinod Kone wrote: > > Ship It! > > Oliver Nicholas wrote: > hey Vinod I know these are two separate systems but would it be possible > for you to get me approved as a committer in Jira so I can actually claim the > underlying task? my username there is "bigo" added you as jira contributor. sorry for the delay. i thought tim already added you. also, this is committed now. thanks for the patch! - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35270/#review87318 --- On June 9, 2015, 11:31 p.m., Oliver Nicholas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35270/ > --- > > (Updated June 9, 2015, 11:31 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-1825 > https://issues.apache.org/jira/browse/MESOS-1825 > > > Repository: mesos > > > Description > --- > > make a bunch of JSONP callback URLs in mesos UI protocol-relative > > > Diffs > - > > src/webui/master/static/js/controllers.js > 93846940ddbbc9f25de9a41f10c899c16e564d88 > src/webui/master/static/js/services.js > 8403aad9b2586ac3c1bea3f75ca38f6f907087a2 > > Diff: https://reviews.apache.org/r/35270/diff/ > > > Testing > --- > > manual; are there tests for this stuff? > > > Thanks, > > Oliver Nicholas > >
Re: Review Request 35270: make a bunch of JSONP callback URLs in mesos UI protocol-relative
> On June 9, 2015, 11:49 p.m., Vinod Kone wrote: > > Ship It! hey Vinod I know these are two separate systems but would it be possible for you to get me approved as a committer in Jira so I can actually claim the underlying task? my username there is "bigo" - Oliver --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35270/#review87318 --- On June 9, 2015, 11:31 p.m., Oliver Nicholas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35270/ > --- > > (Updated June 9, 2015, 11:31 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-1825 > https://issues.apache.org/jira/browse/MESOS-1825 > > > Repository: mesos > > > Description > --- > > make a bunch of JSONP callback URLs in mesos UI protocol-relative > > > Diffs > - > > src/webui/master/static/js/controllers.js > 93846940ddbbc9f25de9a41f10c899c16e564d88 > src/webui/master/static/js/services.js > 8403aad9b2586ac3c1bea3f75ca38f6f907087a2 > > Diff: https://reviews.apache.org/r/35270/diff/ > > > Testing > --- > > manual; are there tests for this stuff? > > > Thanks, > > Oliver Nicholas > >
Re: Review Request 35270: make a bunch of JSONP callback URLs in mesos UI protocol-relative
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35270/#review87326 --- Patch looks great! Reviews applied: [35270] All tests passed. - Mesos ReviewBot On June 9, 2015, 11:31 p.m., Oliver Nicholas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35270/ > --- > > (Updated June 9, 2015, 11:31 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-1825 > https://issues.apache.org/jira/browse/MESOS-1825 > > > Repository: mesos > > > Description > --- > > make a bunch of JSONP callback URLs in mesos UI protocol-relative > > > Diffs > - > > src/webui/master/static/js/controllers.js > 93846940ddbbc9f25de9a41f10c899c16e564d88 > src/webui/master/static/js/services.js > 8403aad9b2586ac3c1bea3f75ca38f6f907087a2 > > Diff: https://reviews.apache.org/r/35270/diff/ > > > Testing > --- > > manual; are there tests for this stuff? > > > Thanks, > > Oliver Nicholas > >
Re: Review Request 35270: make a bunch of JSONP callback URLs in mesos UI protocol-relative
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35270/#review87318 --- Ship it! Ship It! - Vinod Kone On June 9, 2015, 11:31 p.m., Oliver Nicholas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35270/ > --- > > (Updated June 9, 2015, 11:31 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-1825 > https://issues.apache.org/jira/browse/MESOS-1825 > > > Repository: mesos > > > Description > --- > > make a bunch of JSONP callback URLs in mesos UI protocol-relative > > > Diffs > - > > src/webui/master/static/js/controllers.js > 93846940ddbbc9f25de9a41f10c899c16e564d88 > src/webui/master/static/js/services.js > 8403aad9b2586ac3c1bea3f75ca38f6f907087a2 > > Diff: https://reviews.apache.org/r/35270/diff/ > > > Testing > --- > > manual; are there tests for this stuff? > > > Thanks, > > Oliver Nicholas > >
