Re: Review Request 35280: Added Test QoS Controller module

2015-06-11 Thread Niklas Nielsen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35280/
---

(Updated June 11, 2015, 11:55 a.m.)


Review request for mesos, Ben Mahler, Bartek Plotka, and Jie Yu.


Bugs: MESOS-2703
https://issues.apache.org/jira/browse/MESOS-2703


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/Makefile.am 9c6b52a9991a6bebb759e6a307c0593180507477 
  src/examples/test_qos_controller_module.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/35280/diff/


Testing
---

make check.


Thanks,

Niklas Nielsen



Re: Review Request 35280: Added Test QoS Controller module

2015-06-11 Thread Jie Yu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35280/#review87601
---

Ship it!



src/examples/test_qos_controller_module.cpp


This fits in one line?


- Jie Yu


On June 10, 2015, 1:09 a.m., Niklas Nielsen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35280/
> ---
> 
> (Updated June 10, 2015, 1:09 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Bartek Plotka, and Jie Yu.
> 
> 
> Bugs: MESOS-2703
> https://issues.apache.org/jira/browse/MESOS-2703
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 9c6b52a9991a6bebb759e6a307c0593180507477 
>   src/examples/test_qos_controller_module.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/35280/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>



Re: Review Request 35280: Added Test QoS Controller module

2015-06-10 Thread Bartek Plotka

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35280/#review87405
---



src/examples/test_qos_controller_module.cpp


s/Controller  module/Controller module/  (kill one  space)


- Bartek Plotka


On June 10, 2015, 1:09 a.m., Niklas Nielsen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35280/
> ---
> 
> (Updated June 10, 2015, 1:09 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Bartek Plotka, and Jie Yu.
> 
> 
> Bugs: MESOS-2703
> https://issues.apache.org/jira/browse/MESOS-2703
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 9c6b52a9991a6bebb759e6a307c0593180507477 
>   src/examples/test_qos_controller_module.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/35280/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>