Re: Review Request 35565: Refactored os::environment to return a std::map.

2015-06-20 Thread Benjamin Hindman

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35565/
---

(Updated June 20, 2015, 7:01 p.m.)


Review request for mesos and Till Toenshoff.


Bugs: MESOS-2832
https://issues.apache.org/jira/browse/MESOS-2832


Repository: mesos


Description
---

See summary.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
1e7aed0b48b8889eb8d042cbd9f907303d2510d3 
  3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
62987e0df28f28816c59d7cbad89fa2af41ade04 

Diff: https://reviews.apache.org/r/35565/diff/


Testing
---

make check


Thanks,

Benjamin Hindman



Re: Review Request 35565: Refactored os::environment to return a std::map.

2015-06-20 Thread Marco Massenzio

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35565/#review88681
---

Ship it!


Ship It!

- Marco Massenzio


On June 20, 2015, 7:01 p.m., Benjamin Hindman wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/35565/
 ---
 
 (Updated June 20, 2015, 7:01 p.m.)
 
 
 Review request for mesos and Till Toenshoff.
 
 
 Bugs: MESOS-2832
 https://issues.apache.org/jira/browse/MESOS-2832
 
 
 Repository: mesos
 
 
 Description
 ---
 
 See summary.
 
 
 Diffs
 -
 
   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
 1e7aed0b48b8889eb8d042cbd9f907303d2510d3 
   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
 62987e0df28f28816c59d7cbad89fa2af41ade04 
 
 Diff: https://reviews.apache.org/r/35565/diff/
 
 
 Testing
 ---
 
 make check
 
 
 Thanks,
 
 Benjamin Hindman
 




Re: Review Request 35565: Refactored os::environment to return a std::map.

2015-06-17 Thread Till Toenshoff

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35565/#review88319
---

Ship it!


Ship It!

- Till Toenshoff


On June 17, 2015, 2:28 p.m., Benjamin Hindman wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/35565/
 ---
 
 (Updated June 17, 2015, 2:28 p.m.)
 
 
 Review request for mesos and Till Toenshoff.
 
 
 Bugs: MESOS-2832
 https://issues.apache.org/jira/browse/MESOS-2832
 
 
 Repository: mesos
 
 
 Description
 ---
 
 See summary.
 
 
 Diffs
 -
 
   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
 95b4b33b70c37640d97dff5d5724550d42048b76 
   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 
 62987e0df28f28816c59d7cbad89fa2af41ade04 
 
 Diff: https://reviews.apache.org/r/35565/diff/
 
 
 Testing
 ---
 
 make check
 
 
 Thanks,
 
 Benjamin Hindman