On June 20, 2015, 7:35 p.m., Alexander Rukletsov wrote:
Why do we use different approaches (emplace() and insert()) in c-tors? Is
it possible to unify them for clarity? If not, mind leaving a comment
explaining the reasoning?
Great idea, I added a comment as to why we use 'insert'
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35694/
---
(Updated June 24, 2015, 10 p.m.)
Review request for mesos and Till Toenshoff.
On June 20, 2015, 7:35 p.m., Alexander Rukletsov wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp, line 52
https://reviews.apache.org/r/35694/diff/3/?file=988938#file988938line52
Let's avoid re-creating iterator:
```
for (auto iterator =
On June 20, 2015, 7:35 p.m., Alexander Rukletsov wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp, line 52
https://reviews.apache.org/r/35694/diff/3/?file=988938#file988938line52
Let's avoid re-creating iterator:
```
for (auto iterator =
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35694/#review88774
---
Ship it!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35694/
---
(Updated June 20, 2015, 7:06 p.m.)
Review request for mesos and Till
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35694/#review88661
---
Why do we use different approaches (emplace() and insert()) in
