Re: Review Request 35797: Updated FrameworkInfo to update capabilities (Part 1)

2015-06-23 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35797/#review89128
---


Patch looks great!

Reviews applied: [35797]

All tests passed.

- Mesos ReviewBot


On June 24, 2015, 2:44 a.m., Aditi Dixit wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35797/
> ---
> 
> (Updated June 24, 2015, 2:44 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-2880
> https://issues.apache.org/jira/browse/MESOS-2880
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated Frameworkinfo.capabilities on framework re-registration to support 
> adding capabilities
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp af83d3e82d2c161b3cc4583e78a8cbbd2f9a4064 
> 
> Diff: https://reviews.apache.org/r/35797/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Aditi Dixit
> 
>

Re: Review Request 35797: Updated FrameworkInfo to update capabilities (Part 1)

2015-06-23 Thread Aditi Dixit 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35797/
---

(Updated June 24, 2015, 2:44 a.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-2880
https://issues.apache.org/jira/browse/MESOS-2880


Repository: mesos


Description
---

Updated Frameworkinfo.capabilities on framework re-registration to support 
adding capabilities


Diffs (updated)
-

  src/master/master.hpp af83d3e82d2c161b3cc4583e78a8cbbd2f9a4064 

Diff: https://reviews.apache.org/r/35797/diff/


Testing
---

make check


Thanks,

Aditi Dixit

Re: Review Request 35797: Updated FrameworkInfo to update capabilities (Part 1)

2015-06-23 Thread Aditi Dixit 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35797/
---

(Updated June 24, 2015, 2 a.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-2880
https://issues.apache.org/jira/browse/MESOS-2880


Repository: mesos


Description (updated)
---

Updated Frameworkinfo.capabilities on framework re-registration to support 
adding capabilities


Diffs
-

  src/master/master.hpp af83d3e82d2c161b3cc4583e78a8cbbd2f9a4064 

Diff: https://reviews.apache.org/r/35797/diff/


Testing
---

make check


Thanks,

Aditi Dixit

Re: Review Request 35797: Updated FrameworkInfo to update capabilities (Part 1)

2015-06-23 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35797/#review89069
---


Patch looks great!

Reviews applied: [35797]

All tests passed.

- Mesos ReviewBot


On June 23, 2015, 8:08 p.m., Aditi Dixit wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35797/
> ---
> 
> (Updated June 23, 2015, 8:08 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-2880
> https://issues.apache.org/jira/browse/MESOS-2880
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated FrameworkInfo to update capabilities (Part 1)
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp af83d3e82d2c161b3cc4583e78a8cbbd2f9a4064 
> 
> Diff: https://reviews.apache.org/r/35797/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Aditi Dixit
> 
>

Re: Review Request 35797: Updated FrameworkInfo to update capabilities (Part 1)

2015-06-23 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35797/#review89061
---


Couple things:

1) You should write a test for this! Too bad 
https://reviews.apache.org/r/32961/ didn't write new tests you could get 
inspiration from. Take a look at 'FrameworkReregister' test in 
src/tests/fault_tolerance_tests.cpp to get an idea on how to write a test.

2) Update the description in the review. It's not clear what "Part 1" means.


src/master/master.hpp (lines 535 - 539)


I think you can simply do

info.mutable_capabilities()->CopyFrom(source.capabilities());


- Vinod Kone


On June 23, 2015, 8:08 p.m., Aditi Dixit wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35797/
> ---
> 
> (Updated June 23, 2015, 8:08 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-2880
> https://issues.apache.org/jira/browse/MESOS-2880
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated FrameworkInfo to update capabilities (Part 1)
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp af83d3e82d2c161b3cc4583e78a8cbbd2f9a4064 
> 
> Diff: https://reviews.apache.org/r/35797/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Aditi Dixit
> 
>