Re: Review Request 36023: Improved the documentation of Containerizer::launch() to clarify the failure cases.

2015-07-09 Thread Till Toenshoff

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36023/#review91077
---

Ship it!


This is really helpful as it has become a little bit of a confusion milestone 
for many.

- Till Toenshoff


On June 29, 2015, 9:29 p.m., Jiang Yan Xu wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36023/
 ---
 
 (Updated June 29, 2015, 9:29 p.m.)
 
 
 Review request for mesos and Ian Downes.
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Improved the documentation of Containerizer::launch() to clarify the failure 
 cases.
 
 
 Diffs
 -
 
   src/slave/containerizer/containerizer.hpp 
 0ee17e6bc52d1e3acefad6bda3a1b7ba64a8a54b 
 
 Diff: https://reviews.apache.org/r/36023/diff/
 
 
 Testing
 ---
 
 N/A
 
 
 Thanks,
 
 Jiang Yan Xu
 




Re: Review Request 36023: Improved the documentation of Containerizer::launch() to clarify the failure cases.

2015-06-29 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36023/#review89825
---


Patch looks great!

Reviews applied: [36023]

All tests passed.

- Mesos ReviewBot


On June 29, 2015, 9:29 p.m., Jiang Yan Xu wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36023/
 ---
 
 (Updated June 29, 2015, 9:29 p.m.)
 
 
 Review request for mesos and Ian Downes.
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Improved the documentation of Containerizer::launch() to clarify the failure 
 cases.
 
 
 Diffs
 -
 
   src/slave/containerizer/containerizer.hpp 
 0ee17e6bc52d1e3acefad6bda3a1b7ba64a8a54b 
 
 Diff: https://reviews.apache.org/r/36023/diff/
 
 
 Testing
 ---
 
 N/A
 
 
 Thanks,
 
 Jiang Yan Xu