Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

2015-08-13 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated Aug. 13, 2015, 10:57 a.m.) Review request for mesos, Adam B,

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

2015-08-13 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated Aug. 13, 2015, 1:20 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

2015-08-13 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/#review95249 --- Ship it! Fix minor typo, then ship it! (We know that this is not

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

2015-08-13 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated Aug. 13, 2015, 7:08 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

2015-08-13 Thread Alexander Rojas
On Aug. 13, 2015, 6:43 p.m., Timothy Chen wrote: src/authorizer/authorizer.cpp, line 19 https://reviews.apache.org/r/36048/diff/18/?file=1039308#file1039308line19 Is this our new style guide rule too to put this up before all other imports? Otherwise I would have

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

2015-08-13 Thread Till Toenshoff
On Aug. 13, 2015, 8:06 p.m., Till Toenshoff wrote: Thanks for your patience Alexander - I know it has been a long journey - in the end, I think things are in great shape minus some nits I just discovered on my final pass. Please note that I will commit while fixing the noted issues but

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

2015-08-13 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/#review95266 --- Ship it! Thanks for your patience Alexander - I know it has been a

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

2015-08-12 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated Aug. 12, 2015, 4:56 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

2015-08-12 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/#review95096 --- include/mesos/authorizer/authorizer.hpp (line 139)

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

2015-08-12 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/#review95106 --- Good points Alex, can you leave comments on this in the code of to

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

2015-08-12 Thread Alexander Rojas
On Aug. 12, 2015, 5:57 p.m., Timothy Chen wrote: include/mesos/authorizer/authorizer.hpp, line 139 https://reviews.apache.org/r/36048/diff/16/?file=1038383#file1038383line139 Space between operator and The rule changed, we no longer put spaces between operators. Check commit

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

2015-08-12 Thread Bernd Mathiske
On Aug. 12, 2015, 6:04 a.m., Bernd Mathiske wrote: include/mesos/authorizer/authorizer.hpp, line 49 https://reviews.apache.org/r/36048/diff/15/?file=1036353#file1036353line49 If this is only relevant for the default implementation, then this method should be declared there, not

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

2015-08-12 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/#review95079 --- include/mesos/authorizer/authorizer.hpp (line 48)

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

2015-08-12 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated Aug. 12, 2015, 3:52 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

2015-08-10 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated Aug. 10, 2015, 4:35 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

2015-08-10 Thread Alexander Rojas
On Aug. 8, 2015, 11:43 p.m., Michael Park wrote: include/mesos/authorizer/authorizer.hpp, lines 45-47 https://reviews.apache.org/r/36048/diff/14/?file=1033511#file1033511line45 Looks like we call `initialize` even for non-default implementations of `Authenticator`, why do we want

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

2015-08-06 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/#review94395 --- Ship it! Ship It! - Jan Schlicht On Aug. 6, 2015, 1:59 p.m.,

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

2015-08-06 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated Aug. 6, 2015, 1:59 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

2015-08-05 Thread Alexander Rojas
On Aug. 3, 2015, 4:20 p.m., Bernd Mathiske wrote: include/mesos/authorizer/authorizer.proto, line 28 https://reviews.apache.org/r/36048/diff/11/?file=1017127#file1017127line28 What is local authorization? Link or explanation, please! Added the sentence `(See authorization.md file

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

2015-08-05 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated Aug. 5, 2015, 11:04 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

2015-08-04 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated Aug. 4, 2015, 4:13 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

2015-08-04 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/#review94059 --- include/mesos/authorizer/authorizer.hpp (line 83)

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

2015-08-04 Thread Bernd Mathiske
On Aug. 3, 2015, 12:36 p.m., Kapil Arya wrote: I have a stupid question. Why shouldn't the authorizer.{hpp,proto} file be placed inside `include/mesos/master/` instead since the authorizer is only for the master. Does it make sense to do that? If it does, then should we also move

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

2015-08-04 Thread Bernd Mathiske
On Aug. 3, 2015, 12:36 p.m., Kapil Arya wrote: I have a stupid question. Why shouldn't the authorizer.{hpp,proto} file be placed inside `include/mesos/master/` instead since the authorizer is only for the master. Does it make sense to do that? If it does, then should we also move

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

2015-08-03 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/#review93907 --- include/mesos/authorizer/authorizer.hpp (line 24)

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

2015-08-03 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/#review93884 --- Ship it! I think this looks ready for landing after fixing the

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

2015-08-03 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/#review93912 --- src/authorizer/authorizer.cpp (line 209)

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

2015-08-03 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/#review93900 --- include/mesos/authorizer/authorizer.hpp (line 34)

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

2015-08-03 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/#review93951 --- I have a stupid question. Why shouldn't the authorizer.{hpp,proto}

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

2015-07-20 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated July 20, 2015, 11 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

2015-07-07 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated July 7, 2015, 9:33 a.m.) Review request for mesos, Adam B and Till

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

2015-07-06 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated July 6, 2015, 2:38 p.m.) Review request for mesos, Adam B and Till

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

2015-07-06 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated July 6, 2015, 5:41 p.m.) Review request for mesos, Adam B and Till

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

2015-07-06 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated July 6, 2015, 4:18 p.m.) Review request for mesos, Adam B and Till

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

2015-07-03 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated July 3, 2015, 3:15 p.m.) Review request for mesos and Till Toenshoff.

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

2015-07-03 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated July 3, 2015, 9:49 a.m.) Review request for mesos and Till Toenshoff.

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

2015-07-03 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated July 3, 2015, 9:56 a.m.) Review request for mesos and Till Toenshoff.