Re: Review Request 36049: Added support for modularized Authorizer

2015-08-13 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36049/#review95328 --- Ship it! src/local/local.cpp (line 219)

Re: Review Request 36049: Added support for modularized Authorizer

2015-08-12 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36049/ --- (Updated Aug. 12, 2015, 3:52 p.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 36049: Added support for modularized Authorizer

2015-08-10 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36049/ --- (Updated Aug. 10, 2015, 5:29 p.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 36049: Added support for modularized Authorizer

2015-08-09 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36049/#review94664 --- src/local/local.cpp (lines 217 - 219)

Re: Review Request 36049: Added support for modularized Authorizer

2015-08-09 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36049/#review94667 --- src/master/flags.cpp (line 415)

Re: Review Request 36049: Added support for modularized Authorizer

2015-08-05 Thread Alexander Rojas
On Aug. 3, 2015, 4:34 p.m., Bernd Mathiske wrote: src/local/local.cpp, line 221 https://reviews.apache.org/r/36049/diff/8/?file=1017149#file1017149line221 That's a bit too subtle for me. Proposals, either: - pass the acls to the custom authorizer and let it decide what to do

Re: Review Request 36049: Added support for modularized Authorizer

2015-08-05 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36049/#review94207 --- Ship it! src/local/local.cpp (line 226)

Re: Review Request 36049: Added support for modularized Authorizer

2015-08-04 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36049/#review94023 --- Ship it! Ship It! - Jan Schlicht On Aug. 3, 2015, 11:47 a.m.,

Re: Review Request 36049: Added support for modularized Authorizer

2015-08-04 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36049/ --- (Updated Aug. 4, 2015, 6:26 p.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 36049: Added support for modularized Authorizer

2015-08-03 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36049/#review93906 --- src/local/local.cpp (line 221)

Re: Review Request 36049: Added support for modularized Authorizer

2015-08-03 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36049/#review93898 --- Ship it! Ship It! - Till Toenshoff On Aug. 3, 2015, 9:47 a.m.,

Re: Review Request 36049: Added support for modularized Authorizer

2015-07-20 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36049/ --- (Updated July 20, 2015, 11:01 p.m.) Review request for mesos, Adam B and Till

Re: Review Request 36049: Added support for modularized Authorizer

2015-07-17 Thread Alexander Rojas
On July 8, 2015, 12:12 a.m., Till Toenshoff wrote: src/local/local.cpp, line 241 https://reviews.apache.org/r/36049/diff/7/?file=1000249#file1000249line241 I am assuming that the `LocalAuthorizer` should be considered unusable should its initialize function ever fail.

Re: Review Request 36049: Added support for modularized Authorizer

2015-07-07 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36049/ --- (Updated July 7, 2015, 9:34 a.m.) Review request for mesos, Adam B and Till

Re: Review Request 36049: Added support for modularized Authorizer

2015-07-07 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36049/#review90774 --- There are some nits and slight inconsistencies but overall I think

Re: Review Request 36049: Added support for modularized Authorizer

2015-07-06 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36049/ --- (Updated July 6, 2015, 5:42 p.m.) Review request for mesos, Adam B and Till

Re: Review Request 36049: Added support for modularized Authorizer

2015-07-03 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36049/ --- (Updated July 3, 2015, 3:17 p.m.) Review request for mesos and Till Toenshoff.

Re: Review Request 36049: Added support for modularized Authorizer

2015-07-03 Thread Alexander Rojas
On July 3, 2015, 10:29 a.m., Till Toenshoff wrote: src/authorizer/authorizer.cpp, lines 17-28 https://reviews.apache.org/r/36049/diff/5/?file=998603#file998603line17 Great update! But it seems the comment is not applying, no? The built-in authorizer factory

Re: Review Request 36049: Added support for modularized Authorizer

2015-07-03 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36049/ --- (Updated July 3, 2015, 3:40 p.m.) Review request for mesos and Till Toenshoff.

Re: Review Request 36049: Added support for modularized Authorizer

2015-07-03 Thread Till Toenshoff
On July 3, 2015, 8:29 a.m., Till Toenshoff wrote: Let's also update the description of this RR; ``` Adds and integrates helper classes needed to support an Authorizer module. Also adds a flag to the master, allowing the selection of an Authorizer module. ``` or maybe better `.. Authorizer

Re: Review Request 36049: Added support for modularized Authorizer

2015-07-03 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36049/#review90317 --- src/authorizer/authorizer.cpp (lines 17 - 28)

Re: Review Request 36049: Added support for modularized Authorizer

2015-07-03 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36049/#review90341 --- src/master/flags.cpp (line 422)

Re: Review Request 36049: Added support for modularized Authorizer

2015-07-02 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36049/ --- (Updated July 2, 2015, 12:25 p.m.) Review request for mesos and Till

Re: Review Request 36049: Added support for modularized Authorizer

2015-07-02 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36049/ --- (Updated July 3, 2015, 1:34 a.m.) Review request for mesos and Till Toenshoff.