Re: Review Request 36050: Added test authorizer module.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36050/#review95251 --- Ship it! Ship It! - Bernd Mathiske On Aug. 12, 2015, 6:52 a.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36050/ --- (Updated Aug. 12, 2015, 6:52 a.m.) Review request for mesos, Adam B, Bernd Mathiske, Jan Schlicht, and Till Toenshoff. Bugs: MESOS-2947 https://issues.apache.org/jira/browse/MESOS-2947 Repository: mesos Description --- Adds a test authorizer module. Updates the authorization tests in order to perform typed tests on the default authorizer implementation and on the test authorizer module. Diffs - src/Makefile.am 942003149b071a322933e2c085d9122903f69713 src/examples/test_authorizer_module.cpp PRE-CREATION src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87 src/tests/module.hpp 03756a2536ca3e662ba422e96d121a6c39bb8c84 src/tests/module.cpp 61d4753f0f098005f56dd4a24984e30405c32558 Diff: https://reviews.apache.org/r/36050/diff/ Testing --- make check Thanks, Alexander Rojas
Re: Review Request 36050: Added test authorizer module.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36050/#review95330 --- Ship it! Ship It! - Till Toenshoff On Aug. 12, 2015, 1:52 p.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36050/ --- (Updated Aug. 12, 2015, 1:52 p.m.) Review request for mesos, Adam B, Bernd Mathiske, Jan Schlicht, and Till Toenshoff. Bugs: MESOS-2947 https://issues.apache.org/jira/browse/MESOS-2947 Repository: mesos Description --- Adds a test authorizer module. Updates the authorization tests in order to perform typed tests on the default authorizer implementation and on the test authorizer module. Diffs - src/Makefile.am 942003149b071a322933e2c085d9122903f69713 src/examples/test_authorizer_module.cpp PRE-CREATION src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87 src/tests/module.hpp 03756a2536ca3e662ba422e96d121a6c39bb8c84 src/tests/module.cpp 61d4753f0f098005f56dd4a24984e30405c32558 Diff: https://reviews.apache.org/r/36050/diff/ Testing --- make check Thanks, Alexander Rojas
Re: Review Request 36050: Added test authorizer module.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36050/ --- (Updated Aug. 12, 2015, 3:52 p.m.) Review request for mesos, Adam B, Bernd Mathiske, Jan Schlicht, and Till Toenshoff. Bugs: MESOS-2947 https://issues.apache.org/jira/browse/MESOS-2947 Repository: mesos Description --- Adds a test authorizer module. Updates the authorization tests in order to perform typed tests on the default authorizer implementation and on the test authorizer module. Diffs - src/Makefile.am 942003149b071a322933e2c085d9122903f69713 src/examples/test_authorizer_module.cpp PRE-CREATION src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87 src/tests/module.hpp 03756a2536ca3e662ba422e96d121a6c39bb8c84 src/tests/module.cpp 61d4753f0f098005f56dd4a24984e30405c32558 Diff: https://reviews.apache.org/r/36050/diff/ Testing --- make check Thanks, Alexander Rojas
Re: Review Request 36050: Added test authorizer module.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36050/ --- (Updated Aug. 10, 2015, 5:36 p.m.) Review request for mesos, Adam B, Bernd Mathiske, Jan Schlicht, and Till Toenshoff. Changes --- mcypark review. Bugs: MESOS-2947 https://issues.apache.org/jira/browse/MESOS-2947 Repository: mesos Description --- Adds a test authorizer module. Updates the authorization tests in order to perform typed tests on the default authorizer implementation and on the test authorizer module. Diffs (updated) - src/Makefile.am 942003149b071a322933e2c085d9122903f69713 src/examples/test_authorizer_module.cpp PRE-CREATION src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87 src/tests/module.hpp 03756a2536ca3e662ba422e96d121a6c39bb8c84 src/tests/module.cpp 61d4753f0f098005f56dd4a24984e30405c32558 Diff: https://reviews.apache.org/r/36050/diff/ Testing --- make check Thanks, Alexander Rojas
Re: Review Request 36050: Added test authorizer module.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36050/ --- (Updated Aug. 5, 2015, 11:04 a.m.) Review request for mesos, Adam B, Bernd Mathiske, Jan Schlicht, and Till Toenshoff. Changes --- Removed unnecesary header. Bugs: MESOS-2947 https://issues.apache.org/jira/browse/MESOS-2947 Repository: mesos Description --- Adds a test authorizer module. Updates the authorization tests in order to perform typed tests on the default authorizer implementation and on the test authorizer module. Diffs (updated) - src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec src/examples/test_authorizer_module.cpp PRE-CREATION src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87 src/tests/module.hpp 03756a2536ca3e662ba422e96d121a6c39bb8c84 src/tests/module.cpp 61d4753f0f098005f56dd4a24984e30405c32558 Diff: https://reviews.apache.org/r/36050/diff/ Testing --- make check Thanks, Alexander Rojas
Re: Review Request 36050: Added test authorizer module.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36050/#review94209 --- Ship it! Ship It! - Jan Schlicht On Aug. 5, 2015, 11:04 a.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36050/ --- (Updated Aug. 5, 2015, 11:04 a.m.) Review request for mesos, Adam B, Bernd Mathiske, Jan Schlicht, and Till Toenshoff. Bugs: MESOS-2947 https://issues.apache.org/jira/browse/MESOS-2947 Repository: mesos Description --- Adds a test authorizer module. Updates the authorization tests in order to perform typed tests on the default authorizer implementation and on the test authorizer module. Diffs - src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec src/examples/test_authorizer_module.cpp PRE-CREATION src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87 src/tests/module.hpp 03756a2536ca3e662ba422e96d121a6c39bb8c84 src/tests/module.cpp 61d4753f0f098005f56dd4a24984e30405c32558 Diff: https://reviews.apache.org/r/36050/diff/ Testing --- make check Thanks, Alexander Rojas
Re: Review Request 36050: Added test authorizer module.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36050/#review94027 --- Ship it! Ship It! - Jan Schlicht On Aug. 3, 2015, 11:47 a.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36050/ --- (Updated Aug. 3, 2015, 11:47 a.m.) Review request for mesos, Adam B, Bernd Mathiske, Jan Schlicht, and Till Toenshoff. Bugs: MESOS-2947 https://issues.apache.org/jira/browse/MESOS-2947 Repository: mesos Description --- Adds a test authorizer module. Updates the authorization tests in order to perform typed tests on the default authorizer implementation and on the test authorizer module. Diffs - src/Makefile.am addb63f615f16ae6b25f745b2e79fd9fc0e27851 src/examples/test_authorizer_module.cpp PRE-CREATION src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87 src/tests/module.hpp 03756a2536ca3e662ba422e96d121a6c39bb8c84 src/tests/module.cpp 61d4753f0f098005f56dd4a24984e30405c32558 Diff: https://reviews.apache.org/r/36050/diff/ Testing --- make check Thanks, Alexander Rojas
Re: Review Request 36050: Added test authorizer module.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36050/ --- (Updated Aug. 4, 2015, 6:27 p.m.) Review request for mesos, Adam B, Bernd Mathiske, Jan Schlicht, and Till Toenshoff. Bugs: MESOS-2947 https://issues.apache.org/jira/browse/MESOS-2947 Repository: mesos Description --- Adds a test authorizer module. Updates the authorization tests in order to perform typed tests on the default authorizer implementation and on the test authorizer module. Diffs (updated) - src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec src/examples/test_authorizer_module.cpp PRE-CREATION src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87 src/tests/module.hpp 03756a2536ca3e662ba422e96d121a6c39bb8c84 src/tests/module.cpp 61d4753f0f098005f56dd4a24984e30405c32558 Diff: https://reviews.apache.org/r/36050/diff/ Testing --- make check Thanks, Alexander Rojas
Re: Review Request 36050: Added test authorizer module.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36050/#review93899 --- Ship it! src/tests/authorization_tests.cpp (line 25) https://reviews.apache.org/r/36050/#comment148316 This include should go above the process/future.hpp - Till Toenshoff On Aug. 3, 2015, 9:47 a.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36050/ --- (Updated Aug. 3, 2015, 9:47 a.m.) Review request for mesos, Adam B, Bernd Mathiske, Jan Schlicht, and Till Toenshoff. Bugs: MESOS-2947 https://issues.apache.org/jira/browse/MESOS-2947 Repository: mesos Description --- Adds a test authorizer module. Updates the authorization tests in order to perform typed tests on the default authorizer implementation and on the test authorizer module. Diffs - src/Makefile.am addb63f615f16ae6b25f745b2e79fd9fc0e27851 src/examples/test_authorizer_module.cpp PRE-CREATION src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87 src/tests/module.hpp 03756a2536ca3e662ba422e96d121a6c39bb8c84 src/tests/module.cpp 61d4753f0f098005f56dd4a24984e30405c32558 Diff: https://reviews.apache.org/r/36050/diff/ Testing --- make check Thanks, Alexander Rojas
Re: Review Request 36050: Added test authorizer module
On July 2, 2015, 12:51 p.m., Alexander Rukletsov wrote: src/tests/authorization_tests.cpp, lines 43-45 https://reviews.apache.org/r/36050/diff/4/?file=998232#file998232line43 Let's format it according to `clang-format`: ``` typedef ::testing::TypesLocalAuthorizer, tests::ModuleAuthorizer, TestLocalAuthorizer AuthorizerTestTypes; ``` I find that a great readability improvement. - Till --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36050/#review90214 --- On July 2, 2015, 11:18 p.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36050/ --- (Updated July 2, 2015, 11:18 p.m.) Review request for mesos and Till Toenshoff. Bugs: MESOS-2945 https://issues.apache.org/jira/browse/MESOS-2945 Repository: mesos Description --- Adds a test authorizer module. Updates the authorization tests in order to perform typed tests on the default authorizer implementation and on the test authorizer module. Diffs - src/Makefile.am addb63f615f16ae6b25f745b2e79fd9fc0e27851 src/examples/test_authorizer_module.cpp PRE-CREATION src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87 src/tests/module.hpp 03756a2536ca3e662ba422e96d121a6c39bb8c84 src/tests/module.cpp 61d4753f0f098005f56dd4a24984e30405c32558 Diff: https://reviews.apache.org/r/36050/diff/ Testing --- make check Thanks, Alexander Rojas
Re: Review Request 36050: Added test authorizer module
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36050/ --- (Updated July 2, 2015, 12:16 p.m.) Review request for mesos and Till Toenshoff. Changes --- addresses Kapil's reviews. Bugs: MESOS-2945 https://issues.apache.org/jira/browse/MESOS-2945 Repository: mesos Description --- Adds a test authorizer module. Updates the authorization tests in order to perform typed tests on the default authorizer implementation and on the test authorizer module. Diffs (updated) - include/mesos/module/authorizer.hpp PRE-CREATION src/Makefile.am addb63f615f16ae6b25f745b2e79fd9fc0e27851 src/examples/test_authorizer_module.cpp PRE-CREATION src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87 src/tests/module.hpp 03756a2536ca3e662ba422e96d121a6c39bb8c84 src/tests/module.cpp 61d4753f0f098005f56dd4a24984e30405c32558 Diff: https://reviews.apache.org/r/36050/diff/ Testing --- make check Thanks, Alexander Rojas
Re: Review Request 36050: Added test authorizer module
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36050/ --- (Updated July 2, 2015, 12:28 p.m.) Review request for mesos and Till Toenshoff. Changes --- Fix includes. Bugs: MESOS-2945 https://issues.apache.org/jira/browse/MESOS-2945 Repository: mesos Description --- Adds a test authorizer module. Updates the authorization tests in order to perform typed tests on the default authorizer implementation and on the test authorizer module. Diffs (updated) - src/Makefile.am addb63f615f16ae6b25f745b2e79fd9fc0e27851 src/examples/test_authorizer_module.cpp PRE-CREATION src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87 src/tests/module.hpp 03756a2536ca3e662ba422e96d121a6c39bb8c84 src/tests/module.cpp 61d4753f0f098005f56dd4a24984e30405c32558 Diff: https://reviews.apache.org/r/36050/diff/ Testing --- make check Thanks, Alexander Rojas
Re: Review Request 36050: Added test authorizer module
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36050/ --- (Updated July 3, 2015, 1:18 a.m.) Review request for mesos and Till Toenshoff. Changes --- Addresses Alex's review issues. Bugs: MESOS-2945 https://issues.apache.org/jira/browse/MESOS-2945 Repository: mesos Description --- Adds a test authorizer module. Updates the authorization tests in order to perform typed tests on the default authorizer implementation and on the test authorizer module. Diffs (updated) - src/Makefile.am addb63f615f16ae6b25f745b2e79fd9fc0e27851 src/examples/test_authorizer_module.cpp PRE-CREATION src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87 src/tests/module.hpp 03756a2536ca3e662ba422e96d121a6c39bb8c84 src/tests/module.cpp 61d4753f0f098005f56dd4a24984e30405c32558 Diff: https://reviews.apache.org/r/36050/diff/ Testing --- make check Thanks, Alexander Rojas
