Re: Review Request 36114: perf: added another extract function to support the new perf format after v3.12.

2015-07-03 Thread Chi Zhang
On July 2, 2015, 11:44 p.m., Ben Mahler wrote: src/linux/perf.cpp, line 496 https://reviews.apache.org/r/36114/diff/2/?file=998617#file998617line496 Sorry for the drive-by comment, but why not just have a single 'extract' that based on the 'Version' performs the necessary

Re: Review Request 36114: perf: added another extract function to support the new perf format after v3.12.

2015-07-02 Thread Chi Zhang
On July 2, 2015, 12:52 a.m., Paul Brett wrote: src/linux/perf.cpp, line 473 https://reviews.apache.org/r/36114/diff/1/?file=997704#file997704line473 How about extract_post_linux_2_6_39 for the name? I wanted it that too, but functions names need to be lowerCamerl per style guide.

Re: Review Request 36114: perf: added another extract function to support the new perf format after v3.12.

2015-07-02 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36114/#review90294 --- src/linux/perf.cpp (line 496)

Re: Review Request 36114: perf: added another extract function to support the new perf format after v3.12.

2015-07-02 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36114/ --- (Updated July 2, 2015, 11:40 p.m.) Review request for mesos, Ian Downes, Paul

Re: Review Request 36114: perf: added another extract function to support the new perf format after v3.12.

2015-07-01 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36114/#review90170 --- src/linux/perf.cpp (line 473)

Re: Review Request 36114: perf: added another extract function to support the new perf format after v3.12.

2015-07-01 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36114/#review90180 --- src/linux/perf.cpp (line 473)