Re: Review Request 36127: Removing '.json' extension in files endpoints url
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36127/#review98581 --- Patch looks great! Reviews applied: [36126, 36125, 36127] All tests passed. - Mesos ReviewBot On Sept. 10, 2015, 9:46 p.m., Isabel Jimenez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36127/ > --- > > (Updated Sept. 10, 2015, 9:46 p.m.) > > > Review request for mesos, Adam B, Anand Mazumdar, Ben Mahler, Marco > Massenzio, and Vinod Kone. > > > Bugs: MESOS-2984 > https://issues.apache.org/jira/browse/MESOS-2984 > > > Repository: mesos-incubating > > > Description > --- > > Removing json extension for HTTP endpoints in files > > > Diffs > - > > docs/configuration.md 315dc53 > src/cli/mesos-cat 73dc63e > src/cli/mesos-tail 256a804 > src/files/files.cpp a8807b6 > src/master/flags.cpp 230c1dc > src/slave/flags.cpp b676bac > src/tests/files_tests.cpp 53771cd > src/tests/gc_tests.cpp ec27ac7 > src/webui/master/static/browse.html 0904c87 > src/webui/master/static/js/controllers.js fbf8696 > > Diff: https://reviews.apache.org/r/36127/diff/ > > > Testing > --- > > make check > > > Thanks, > > Isabel Jimenez > >
Re: Review Request 36127: Removing '.json' extension in files endpoints url
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36127/ --- (Updated Sept. 11, 2015, 9:48 p.m.) Review request for mesos, Adam B, Anand Mazumdar, Ben Mahler, Marco Massenzio, and Vinod Kone. Changes --- rebase Bugs: MESOS-2984 https://issues.apache.org/jira/browse/MESOS-2984 Repository: mesos-incubating Description --- Removing json extension for HTTP endpoints in files Diffs (updated) - docs/configuration.md 315dc53 src/cli/mesos-cat 73dc63e src/cli/mesos-tail 256a804 src/files/files.cpp a8807b6 src/master/flags.cpp 230c1dc src/slave/flags.cpp b676bac src/tests/files_tests.cpp 53771cd src/tests/gc_tests.cpp ec27ac7 src/webui/master/static/browse.html 0904c87 src/webui/master/static/js/controllers.js fbf8696 Diff: https://reviews.apache.org/r/36127/diff/ Testing --- make check Thanks, Isabel Jimenez
Re: Review Request 36127: Removing '.json' extension in files endpoints url
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36127/ --- (Updated Sept. 10, 2015, 5:58 p.m.) Review request for mesos, Adam B, Anand Mazumdar, Ben Mahler, Marco Massenzio, and Vinod Kone. Bugs: MESOS-2984 https://issues.apache.org/jira/browse/MESOS-2984 Repository: mesos-incubating Description --- Removing json extension for HTTP endpoints in files Diffs (updated) - docs/configuration.md 315dc53 src/cli/mesos-cat 73dc63e src/cli/mesos-tail 256a804 src/files/files.cpp b2134aa src/master/flags.cpp 230c1dc src/slave/flags.cpp 7539441 src/tests/files_tests.cpp 53771cd src/tests/gc_tests.cpp ec27ac7 src/webui/master/static/browse.html 0904c87 src/webui/master/static/js/controllers.js 3445028 Diff: https://reviews.apache.org/r/36127/diff/ Testing --- make check Thanks, Isabel Jimenez
Re: Review Request 36127: Removing '.json' extension in files endpoints url
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36127/ --- (Updated Sept. 10, 2015, 5:59 p.m.) Review request for mesos, Adam B, Anand Mazumdar, Ben Mahler, Marco Massenzio, and Vinod Kone. Bugs: MESOS-2984 https://issues.apache.org/jira/browse/MESOS-2984 Repository: mesos-incubating Description --- Removing json extension for HTTP endpoints in files Diffs - docs/configuration.md 315dc53 src/cli/mesos-cat 73dc63e src/cli/mesos-tail 256a804 src/files/files.cpp b2134aa src/master/flags.cpp 230c1dc src/slave/flags.cpp 7539441 src/tests/files_tests.cpp 53771cd src/tests/gc_tests.cpp ec27ac7 src/webui/master/static/browse.html 0904c87 src/webui/master/static/js/controllers.js 3445028 Diff: https://reviews.apache.org/r/36127/diff/ Testing --- make check Thanks, Isabel Jimenez
Re: Review Request 36127: Removing '.json' extension in files endpoints url
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36127/#review98454 --- Bad patch! Reviews applied: [36126] Failed command: ./support/apply-review.sh -n -r 36126 Error: 2015-09-10 19:01:59 URL:https://reviews.apache.org/r/36126/diff/raw/ [14060/14060] -> "36126.patch" [1] error: patch failed: src/slave/http.cpp:202 error: src/slave/http.cpp: patch does not apply error: patch failed: src/slave/monitor.cpp:48 error: src/slave/monitor.cpp: patch does not apply Failed to apply patch - Mesos ReviewBot On Sept. 10, 2015, 5:59 p.m., Isabel Jimenez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36127/ > --- > > (Updated Sept. 10, 2015, 5:59 p.m.) > > > Review request for mesos, Adam B, Anand Mazumdar, Ben Mahler, Marco > Massenzio, and Vinod Kone. > > > Bugs: MESOS-2984 > https://issues.apache.org/jira/browse/MESOS-2984 > > > Repository: mesos-incubating > > > Description > --- > > Removing json extension for HTTP endpoints in files > > > Diffs > - > > docs/configuration.md 315dc53 > src/cli/mesos-cat 73dc63e > src/cli/mesos-tail 256a804 > src/files/files.cpp b2134aa > src/master/flags.cpp 230c1dc > src/slave/flags.cpp 7539441 > src/tests/files_tests.cpp 53771cd > src/tests/gc_tests.cpp ec27ac7 > src/webui/master/static/browse.html 0904c87 > src/webui/master/static/js/controllers.js 3445028 > > Diff: https://reviews.apache.org/r/36127/diff/ > > > Testing > --- > > make check > > > Thanks, > > Isabel Jimenez > >
Re: Review Request 36127: Removing '.json' extension in files endpoints url
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36127/ --- (Updated Sept. 10, 2015, 9:46 p.m.) Review request for mesos, Adam B, Anand Mazumdar, Ben Mahler, Marco Massenzio, and Vinod Kone. Changes --- rebase Bugs: MESOS-2984 https://issues.apache.org/jira/browse/MESOS-2984 Repository: mesos-incubating Description --- Removing json extension for HTTP endpoints in files Diffs (updated) - docs/configuration.md 315dc53 src/cli/mesos-cat 73dc63e src/cli/mesos-tail 256a804 src/files/files.cpp a8807b6 src/master/flags.cpp 230c1dc src/slave/flags.cpp b676bac src/tests/files_tests.cpp 53771cd src/tests/gc_tests.cpp ec27ac7 src/webui/master/static/browse.html 0904c87 src/webui/master/static/js/controllers.js fbf8696 Diff: https://reviews.apache.org/r/36127/diff/ Testing --- make check Thanks, Isabel Jimenez
Re: Review Request 36127: Removing '.json' extension in files endpoints url
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36127/#review96218 --- Patch looks great! Reviews applied: [36127] All tests passed. - Mesos ReviewBot On Aug. 23, 2015, 5:45 a.m., Isabel Jimenez wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36127/ --- (Updated Aug. 23, 2015, 5:45 a.m.) Review request for mesos, Anand Mazumdar, Ben Mahler, Marco Massenzio, and Vinod Kone. Bugs: MESOS-2984 https://issues.apache.org/jira/browse/MESOS-2984 Repository: mesos-incubating Description --- Removing json extension for HTTP endpoints in files Diffs - docs/configuration.md 2b23d48 src/cli/mesos-cat 73dc63e src/cli/mesos-tail 256a804 src/files/files.cpp a94a5ee src/master/flags.cpp 230c1dc src/slave/flags.cpp b36710d src/tests/files_tests.cpp 53771cd src/tests/gc_tests.cpp ec27ac7 src/webui/master/static/browse.html 0904c87 src/webui/master/static/js/controllers.js 3445028 Diff: https://reviews.apache.org/r/36127/diff/ Testing --- make check Thanks, Isabel Jimenez
Re: Review Request 36127: Removing '.json' extension in files endpoints url
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36127/ --- (Updated Aug. 23, 2015, 5:30 a.m.) Review request for mesos, Anand Mazumdar, Ben Mahler, Marco Massenzio, and Vinod Kone. Bugs: MESOS-2984 https://issues.apache.org/jira/browse/MESOS-2984 Repository: mesos-incubating Description --- Removing json extension for HTTP endpoints in files Diffs (updated) - docs/configuration.md 2b23d48 src/cli/mesos-cat 73dc63e src/cli/mesos-tail 256a804 src/files/files.cpp a94a5ee src/master/flags.cpp 230c1dc src/slave/flags.cpp b36710d src/tests/files_tests.cpp 53771cd src/tests/gc_tests.cpp ec27ac7 src/webui/master/static/browse.html 0904c87 src/webui/master/static/js/controllers.js 3445028 Diff: https://reviews.apache.org/r/36127/diff/ Testing --- make check Thanks, Isabel Jimenez
Re: Review Request 36127: Removing '.json' extension in files endpoints url
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36127/ --- (Updated Aug. 23, 2015, 5:45 a.m.) Review request for mesos, Anand Mazumdar, Ben Mahler, Marco Massenzio, and Vinod Kone. Bugs: MESOS-2984 https://issues.apache.org/jira/browse/MESOS-2984 Repository: mesos-incubating Description --- Removing json extension for HTTP endpoints in files Diffs (updated) - docs/configuration.md 2b23d48 src/cli/mesos-cat 73dc63e src/cli/mesos-tail 256a804 src/files/files.cpp a94a5ee src/master/flags.cpp 230c1dc src/slave/flags.cpp b36710d src/tests/files_tests.cpp 53771cd src/tests/gc_tests.cpp ec27ac7 src/webui/master/static/browse.html 0904c87 src/webui/master/static/js/controllers.js 3445028 Diff: https://reviews.apache.org/r/36127/diff/ Testing --- make check Thanks, Isabel Jimenez
Re: Review Request 36127: Removing '.json' extension in files endpoints url
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36127/#review95500 --- Is this patch still needed? both this and the associated Jira have not been updated in more than a month. - Marco Massenzio On July 2, 2015, 8:03 a.m., Isabel Jimenez wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36127/ --- (Updated July 2, 2015, 8:03 a.m.) Review request for mesos, Anand Mazumdar, Ben Mahler, Marco Massenzio, and Vinod Kone. Bugs: MESOS-2984 https://issues.apache.org/jira/browse/MESOS-2984 Repository: mesos-incubating Description --- Removing json extension for HTTP endpoints in files Diffs - src/cli/mesos-cat 73dc63e src/cli/mesos-tail 256a804 src/files/files.cpp 3a62ee7 src/master/flags.cpp 60ac64d src/slave/flags.cpp 8632677 src/tests/files_tests.cpp 53771cd src/tests/gc_tests.cpp 5666cd1 src/webui/master/static/browse.html 0904c87 src/webui/master/static/js/controllers.js 3445028 Diff: https://reviews.apache.org/r/36127/diff/ Testing --- make check Thanks, Isabel Jimenez
Re: Review Request 36127: Removing '.json' extension in files endpoints url
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36127/#review90378 --- Patch looks great! Reviews applied: [36127] All tests passed. - Mesos ReviewBot On July 2, 2015, 8:03 a.m., Isabel Jimenez wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36127/ --- (Updated July 2, 2015, 8:03 a.m.) Review request for mesos, Anand Mazumdar, Ben Mahler, Marco Massenzio, and Vinod Kone. Bugs: MESOS-2984 https://issues.apache.org/jira/browse/MESOS-2984 Repository: mesos-incubating Description --- Removing json extension for HTTP endpoints in files Diffs - src/cli/mesos-cat 73dc63e src/cli/mesos-tail 256a804 src/files/files.cpp 3a62ee7 src/master/flags.cpp 60ac64d src/slave/flags.cpp 8632677 src/tests/files_tests.cpp 53771cd src/tests/gc_tests.cpp 5666cd1 src/webui/master/static/browse.html 0904c87 src/webui/master/static/js/controllers.js 3445028 Diff: https://reviews.apache.org/r/36127/diff/ Testing --- make check Thanks, Isabel Jimenez
