Re: Review Request 36204: Pass slave's total resources in ResourceUsage.

2015-07-07 Thread Bartek Plotka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36204/ --- (Updated July 7, 2015, 5:50 p.m.) Review request for mesos, Ben Mahler, Jie Yu,

Re: Review Request 36204: Pass slave's total resources in ResourceUsage.

2015-07-07 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36204/#review90727 --- Ship it! LGTM! Could you please add a follow up patch to test this

Re: Review Request 36204: Pass slave's total resources in ResourceUsage.

2015-07-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36204/#review90722 --- Patch looks great! Reviews applied: [36204] All tests passed. - M

Re: Review Request 36204: Pass slave's total resources in ResourceUsage.

2015-07-07 Thread Bartek Plotka
> On July 6, 2015, 5:50 p.m., Jie Yu wrote: > > src/slave/slave.cpp, line 4379 > > > > > > Per my comments above, the logic here needs to be adjusted. We need to > > apply checkpointed resource to info.resources()

Re: Review Request 36204: Pass slave's total resources in ResourceUsage.

2015-07-07 Thread Bartek Plotka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36204/ --- (Updated July 7, 2015, 4:20 p.m.) Review request for mesos, Ben Mahler, Jie Yu,

Re: Review Request 36204: Pass slave's total resources in ResourceUsage.

2015-07-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36204/#review90516 --- Patch looks great! Reviews applied: [36204] All tests passed. - M

Re: Review Request 36204: Pass slave's total resources in ResourceUsage.

2015-07-06 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36204/#review90510 --- Thanks Bartek! See my detailed comments. include/mesos/mesos.proto