Re: Review Request 36245: Fix compilation error for clang-3.5 type deduction error.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36245/#review90699 --- Ship it! Ship It! - Benjamin Hindman On July 7, 2015, 5:16 a.m., Joris Van Remoortere wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36245/ > --- > > (Updated July 7, 2015, 5:16 a.m.) > > > Review request for mesos, Benjamin Hindman and Michael Park. > > > Bugs: MESOS-2943 > https://issues.apache.org/jira/browse/MESOS-2943 > > > Repository: mesos > > > Description > --- > > While we figure out how to avoid this bug in clang-3.5, we can allow people > to compile by explicitly specifying the return type of the lambda. > > > Diffs > - > > 3rdparty/libprocess/src/libevent_ssl_socket.cpp > 9424dd421b290bec25b4a7c4dc0071ffef6fdc5e > > Diff: https://reviews.apache.org/r/36245/diff/ > > > Testing > --- > > make check 3rdparty using clang-3.5 > > > Thanks, > > Joris Van Remoortere > >
Re: Review Request 36245: Fix compilation error for clang-3.5 type deduction error.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36245/#review90688 --- Ship it! Ship It! - Michael Park On July 7, 2015, 5:16 a.m., Joris Van Remoortere wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36245/ > --- > > (Updated July 7, 2015, 5:16 a.m.) > > > Review request for mesos, Benjamin Hindman and Michael Park. > > > Bugs: MESOS-2943 > https://issues.apache.org/jira/browse/MESOS-2943 > > > Repository: mesos > > > Description > --- > > While we figure out how to avoid this bug in clang-3.5, we can allow people > to compile by explicitly specifying the return type of the lambda. > > > Diffs > - > > 3rdparty/libprocess/src/libevent_ssl_socket.cpp > 9424dd421b290bec25b4a7c4dc0071ffef6fdc5e > > Diff: https://reviews.apache.org/r/36245/diff/ > > > Testing > --- > > make check 3rdparty using clang-3.5 > > > Thanks, > > Joris Van Remoortere > >
Re: Review Request 36245: Fix compilation error for clang-3.5 type deduction error.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36245/#review90653 --- Patch looks great! Reviews applied: [36245] All tests passed. - Mesos ReviewBot On July 7, 2015, 5:16 a.m., Joris Van Remoortere wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36245/ > --- > > (Updated July 7, 2015, 5:16 a.m.) > > > Review request for mesos, Benjamin Hindman and Michael Park. > > > Bugs: MESOS-2943 > https://issues.apache.org/jira/browse/MESOS-2943 > > > Repository: mesos > > > Description > --- > > While we figure out how to avoid this bug in clang-3.5, we can allow people > to compile by explicitly specifying the return type of the lambda. > > > Diffs > - > > 3rdparty/libprocess/src/libevent_ssl_socket.cpp > 9424dd421b290bec25b4a7c4dc0071ffef6fdc5e > > Diff: https://reviews.apache.org/r/36245/diff/ > > > Testing > --- > > make check 3rdparty using clang-3.5 > > > Thanks, > > Joris Van Remoortere > >
Re: Review Request 36245: Fix compilation error for clang-3.5 type deduction error.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36245/#review90650 --- Ship it! Ship It! - Artem Harutyunyan On July 6, 2015, 10:16 p.m., Joris Van Remoortere wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36245/ > --- > > (Updated July 6, 2015, 10:16 p.m.) > > > Review request for mesos, Benjamin Hindman and Michael Park. > > > Bugs: MESOS-2943 > https://issues.apache.org/jira/browse/MESOS-2943 > > > Repository: mesos > > > Description > --- > > While we figure out how to avoid this bug in clang-3.5, we can allow people > to compile by explicitly specifying the return type of the lambda. > > > Diffs > - > > 3rdparty/libprocess/src/libevent_ssl_socket.cpp > 9424dd421b290bec25b4a7c4dc0071ffef6fdc5e > > Diff: https://reviews.apache.org/r/36245/diff/ > > > Testing > --- > > make check 3rdparty using clang-3.5 > > > Thanks, > > Joris Van Remoortere > >
Re: Review Request 36245: Fix compilation error for clang-3.5 type deduction error.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36245/#review90648 --- Ship it! Ship It! - Adam B On July 6, 2015, 10:16 p.m., Joris Van Remoortere wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36245/ > --- > > (Updated July 6, 2015, 10:16 p.m.) > > > Review request for mesos, Benjamin Hindman and Michael Park. > > > Bugs: MESOS-2943 > https://issues.apache.org/jira/browse/MESOS-2943 > > > Repository: mesos > > > Description > --- > > While we figure out how to avoid this bug in clang-3.5, we can allow people > to compile by explicitly specifying the return type of the lambda. > > > Diffs > - > > 3rdparty/libprocess/src/libevent_ssl_socket.cpp > 9424dd421b290bec25b4a7c4dc0071ffef6fdc5e > > Diff: https://reviews.apache.org/r/36245/diff/ > > > Testing > --- > > make check 3rdparty using clang-3.5 > > > Thanks, > > Joris Van Remoortere > >