Re: Review Request 36269: Update CHANGELOG to reflect obsolete code cleanup

2015-09-12 Thread Adam B 


> On July 7, 2015, 11:40 a.m., Vinod Kone wrote:
> > CHANGELOG, line 337
> > 
> >
> > I would just put this under deprecations section.
> > 
> > Also, mind updating MESOS-2058 in deprecation section to do 
> > s/deprecate/remove/ because its been removed.
> 
> Jiang Yan Xu wrote:
> Adam is against putting MESOS-2640 in 0.23.0 because it's committed after 
> rc1 is cut. This review doesn't even need to land now.
> 
> s/deprecate/remove/ on MESOS-2058 can be done separately.
> 
> Vinod Kone wrote:
> SG. Yea I wanted a WIP 24.0 CHANGELOG too when I originially made that 
> comment on the older review. Forgot about that.

@xujyan: I don't think this ever got added to the CHANGELOG, even with 0.24 
released now. Can you please revive this patch so we can update the changelog 
appropriately? Thanks.


- Adam


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36269/#review90756
---


On July 7, 2015, 10:59 a.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36269/
> ---
> 
> (Updated July 7, 2015, 10:59 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Per Vinod's comment on /r/36005
> 
> The `**Cleanup` section makes sense?
> 
> 
> Diffs
> -
> 
>   CHANGELOG 433924a0e614f061c448a8e85d0a2825567150dc 
> 
> Diff: https://reviews.apache.org/r/36269/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 36269: Update CHANGELOG to reflect obsolete code cleanup

2015-07-07 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36269/#review90776
---


Patch looks great!

Reviews applied: [36269]

All tests passed.

- Mesos ReviewBot


On July 7, 2015, 5:59 p.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36269/
> ---
> 
> (Updated July 7, 2015, 5:59 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Per Vinod's comment on /r/36005
> 
> The `**Cleanup` section makes sense?
> 
> 
> Diffs
> -
> 
>   CHANGELOG 433924a0e614f061c448a8e85d0a2825567150dc 
> 
> Diff: https://reviews.apache.org/r/36269/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 36269: Update CHANGELOG to reflect obsolete code cleanup

2015-07-07 Thread Vinod Kone 


> On July 7, 2015, 6:40 p.m., Vinod Kone wrote:
> > CHANGELOG, line 337
> > 
> >
> > I would just put this under deprecations section.
> > 
> > Also, mind updating MESOS-2058 in deprecation section to do 
> > s/deprecate/remove/ because its been removed.
> 
> Jiang Yan Xu wrote:
> Adam is against putting MESOS-2640 in 0.23.0 because it's committed after 
> rc1 is cut. This review doesn't even need to land now.
> 
> s/deprecate/remove/ on MESOS-2058 can be done separately.

SG. Yea I wanted a WIP 24.0 CHANGELOG too when I originially made that comment 
on the older review. Forgot about that.


- Vinod


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36269/#review90756
---


On July 7, 2015, 5:59 p.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36269/
> ---
> 
> (Updated July 7, 2015, 5:59 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Per Vinod's comment on /r/36005
> 
> The `**Cleanup` section makes sense?
> 
> 
> Diffs
> -
> 
>   CHANGELOG 433924a0e614f061c448a8e85d0a2825567150dc 
> 
> Diff: https://reviews.apache.org/r/36269/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 36269: Update CHANGELOG to reflect obsolete code cleanup

2015-07-07 Thread Jiang Yan Xu 


> On July 7, 2015, 11:40 a.m., Vinod Kone wrote:
> > CHANGELOG, line 337
> > 
> >
> > I would just put this under deprecations section.
> > 
> > Also, mind updating MESOS-2058 in deprecation section to do 
> > s/deprecate/remove/ because its been removed.

Adam is against putting MESOS-2640 in 0.23.0 because it's committed after rc1 
is cut. This review doesn't even need to land now.

s/deprecate/remove/ on MESOS-2058 can be done separately.


- Jiang Yan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36269/#review90756
---


On July 7, 2015, 10:59 a.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36269/
> ---
> 
> (Updated July 7, 2015, 10:59 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Per Vinod's comment on /r/36005
> 
> The `**Cleanup` section makes sense?
> 
> 
> Diffs
> -
> 
>   CHANGELOG 433924a0e614f061c448a8e85d0a2825567150dc 
> 
> Diff: https://reviews.apache.org/r/36269/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 36269: Update CHANGELOG to reflect obsolete code cleanup

2015-07-07 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36269/#review90756
---



CHANGELOG (line 337)


I would just put this under deprecations section.

Also, mind updating MESOS-2058 in deprecation section to do 
s/deprecate/remove/ because its been removed.


- Vinod Kone


On July 7, 2015, 5:59 p.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36269/
> ---
> 
> (Updated July 7, 2015, 5:59 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Per Vinod's comment on /r/36005
> 
> The `**Cleanup` section makes sense?
> 
> 
> Diffs
> -
> 
>   CHANGELOG 433924a0e614f061c448a8e85d0a2825567150dc 
> 
> Diff: https://reviews.apache.org/r/36269/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 36269: Update CHANGELOG to reflect obsolete code cleanup

2015-07-07 Thread Jiang Yan Xu 


> On July 7, 2015, 11:35 a.m., Adam B wrote:
> > CHANGELOG, line 337
> > 
> >
> > Do you actually want/need MESOS-2640 to go into 0.23.0?
> > If so, MESOS-2640 should have its Target Version and Fix Version set to 
> > 0.23.0 and the release manager (me) should be notified. Since we've already 
> > cut rc1, we are only cherry-picking select patches into 0.23.0-rc2. Does 
> > this need to be one?
> > 
> > If not, create a new `(WIP) Release Notes - Mesos - Version 0.24.0` 
> > section at the top to place your Cleanup ticket under.

I see. ```(WIP) Release Notes - Mesos - Version 0.24.0``` sounds good.


- Jiang Yan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36269/#review90754
---


On July 7, 2015, 10:59 a.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36269/
> ---
> 
> (Updated July 7, 2015, 10:59 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Per Vinod's comment on /r/36005
> 
> The `**Cleanup` section makes sense?
> 
> 
> Diffs
> -
> 
>   CHANGELOG 433924a0e614f061c448a8e85d0a2825567150dc 
> 
> Diff: https://reviews.apache.org/r/36269/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 36269: Update CHANGELOG to reflect obsolete code cleanup

2015-07-07 Thread Adam B 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36269/#review90754
---


Do you actually want/need MESOS-2640 to go into 0.23.0?


CHANGELOG (line 337)


Do you actually want/need MESOS-2640 to go into 0.23.0?
If so, MESOS-2640 should have its Target Version and Fix Version set to 
0.23.0 and the release manager (me) should be notified. Since we've already cut 
rc1, we are only cherry-picking select patches into 0.23.0-rc2. Does this need 
to be one?

If not, create a new `(WIP) Release Notes - Mesos - Version 0.24.0` section 
at the top to place your Cleanup ticket under.


- Adam B


On July 7, 2015, 10:59 a.m., Jiang Yan Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36269/
> ---
> 
> (Updated July 7, 2015, 10:59 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Per Vinod's comment on /r/36005
> 
> The `**Cleanup` section makes sense?
> 
> 
> Diffs
> -
> 
>   CHANGELOG 433924a0e614f061c448a8e85d0a2825567150dc 
> 
> Diff: https://reviews.apache.org/r/36269/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>