Re: Review Request 36318: Refactored framework struct in master to support http frameworks

2015-07-28 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36318/#review93331 --- Ship it! src/master/master.cpp (line 4841)

Re: Review Request 36318: Refactored framework struct in master to support http frameworks

2015-07-27 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36318/#review93165 --- Nice work Anand! I left feedback here, but it is all addressed in

Re: Review Request 36318: Refactored framework struct in master to support http frameworks

2015-07-27 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36318/ --- (Updated July 28, 2015, 3:47 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36318: Refactored framework struct in master to support http frameworks

2015-07-27 Thread Anand Mazumdar
On July 27, 2015, 11:54 p.m., Ben Mahler wrote: Nice work Anand! I left feedback here, but it is all addressed in the diff I sent you over email. With the diff applied this patch looks like a shippable step to me. Note that per the comments, I also fenced off addFramework for http

Re: Review Request 36318: Refactored framework struct in master to support http frameworks

2015-07-25 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36318/ --- (Updated July 25, 2015, 7:40 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36318: Refactored framework struct in master to support http frameworks

2015-07-25 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36318/ --- (Updated July 25, 2015, 6:49 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36318: Refactored framework struct in master to support http frameworks

2015-07-24 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36318/ --- (Updated July 24, 2015, 9:42 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36318: Refactored framework struct in master to support http frameworks

2015-07-23 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36318/ --- (Updated July 23, 2015, 5:29 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36318: Refactored framework struct in master to support http frameworks

2015-07-22 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36318/ --- (Updated July 23, 2015, 4:25 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36318: Refactored framework struct in master to support http frameworks

2015-07-22 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36318/ --- (Updated July 23, 2015, 5:47 a.m.) Review request for mesos, Benjamin Hindman,