Re: Review Request 36378: Refactor Linux Performance monitor to handle changing 'perf stat' output versions depending on kernel version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36378/#review92128 --- Thanks Paul for taking this on! See my detailed comments. We

Re: Review Request 36378: Refactor Linux Performance monitor to handle changing 'perf stat' output versions depending on kernel version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36378/#review92133 --- src/linux/perf.cpp (line 178)

Re: Review Request 36378: Refactor Linux Performance monitor to handle changing 'perf stat' output versions depending on kernel version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36378/ --- (Updated July 16, 2015, 9:32 p.m.) Review request for mesos, Ben Mahler, Chi

Re: Review Request 36378: Refactor Linux Performance monitor to handle changing 'perf stat' output versions depending on kernel version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36378/ --- (Updated July 13, 2015, 9:02 p.m.) Review request for mesos, Ben Mahler, Chi

Re: Review Request 36378: Refactor Linux Performance monitor to handle changing 'perf stat' output versions depending on kernel version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36378/ --- (Updated July 13, 2015, 9:04 p.m.) Review request for mesos, Ben Mahler, Chi

Re: Review Request 36378: Refactor Linux Performance monitor to handle changing 'perf stat' output versions depending on kernel version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36378/#review91253 --- src/linux/perf.cpp (line 449)

Re: Review Request 36378: Refactor Linux Performance monitor to handle changing 'perf stat' output versions depending on kernel version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36378/ --- (Updated July 10, 2015, 5:33 p.m.) Review request for mesos, Ben Mahler, Chi

Re: Review Request 36378: Refactor Linux Performance monitor to handle changing 'perf stat' output versions depending on kernel version.

On July 10, 2015, 5:25 p.m., Ian Downes wrote: src/linux/perf.cpp, lines 469-474 https://reviews.apache.org/r/36378/diff/1/?file=1004593#file1004593line469 We should document this behavior at os::release() and move this there as an alternative. If it's kept in here

Re: Review Request 36378: Refactor Linux Performance monitor to handle changing 'perf stat' output versions depending on kernel version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36378/ --- (Updated July 10, 2015, 6:16 p.m.) Review request for mesos, Ben Mahler, Chi

Re: Review Request 36378: Refactor Linux Performance monitor to handle changing 'perf stat' output versions depending on kernel version.

On July 10, 2015, 5:25 p.m., Ian Downes wrote: src/linux/perf.cpp, line 482 https://reviews.apache.org/r/36378/diff/1/?file=1004593#file1004593line482 Suggest moving the TODO to here. I'd like to keep it with the definition since usage is in multiple locations in the file. -

Re: Review Request 36378: Refactor Linux Performance monitor to handle changing 'perf stat' output versions depending on kernel version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36378/#review91355 --- src/linux/perf.cpp (line 468)

Re: Review Request 36378: Refactor Linux Performance monitor to handle changing 'perf stat' output versions depending on kernel version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36378/ --- (Updated July 10, 2015, 8:48 p.m.) Review request for mesos, Ben Mahler, Chi