Re: Review Request 36412: Adjusted the revocable cpu isolator test.

2015-07-16 Thread Vinod Kone

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36412/#review91911
---

Ship it!


Ship It!

- Vinod Kone


On July 11, 2015, 12:09 a.m., Jie Yu wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36412/
 ---
 
 (Updated July 11, 2015, 12:09 a.m.)
 
 
 Review request for mesos, Ian Downes and Vinod Kone.
 
 
 Bugs: MESOS-2652
 https://issues.apache.org/jira/browse/MESOS-2652
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Adjusted the revocable cpu isolator test.
 
 
 Diffs
 -
 
   src/tests/isolator_tests.cpp 8eb732fe90dbab11967e663a5c06890f79463488 
 
 Diff: https://reviews.apache.org/r/36412/diff/
 
 
 Testing
 ---
 
 sudo make check
 
 
 Thanks,
 
 Jie Yu
 




Re: Review Request 36412: Adjusted the revocable cpu isolator test.

2015-07-16 Thread Vinod Kone

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36412/#review91914
---



src/tests/isolator_tests.cpp (line 417)
https://reviews.apache.org/r/36412/#comment145630

I would recommend to keep the IDLE check because that code still exists.


- Vinod Kone


On July 11, 2015, 12:09 a.m., Jie Yu wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36412/
 ---
 
 (Updated July 11, 2015, 12:09 a.m.)
 
 
 Review request for mesos, Ian Downes and Vinod Kone.
 
 
 Bugs: MESOS-2652
 https://issues.apache.org/jira/browse/MESOS-2652
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Adjusted the revocable cpu isolator test.
 
 
 Diffs
 -
 
   src/tests/isolator_tests.cpp 8eb732fe90dbab11967e663a5c06890f79463488 
 
 Diff: https://reviews.apache.org/r/36412/diff/
 
 
 Testing
 ---
 
 sudo make check
 
 
 Thanks,
 
 Jie Yu