Re: Review Request 36429: Add filesystem/linux isolator for persistent volumes.

> On July 29, 2015, 4:04 p.m., James DeFelice wrote: > > src/slave/containerizer/isolators/filesystem/linux.cpp, line 238 > > > > > > why MS_SHARED (bidirectional) vs MS_SLAVE (one-way)? > > > > MS_SLAVE wou

Re: Review Request 36429: Add filesystem/linux isolator for persistent volumes.

> On Aug. 11, 2015, 3:57 p.m., Marco Massenzio wrote: > > Wouldn't it be good if we could have some comments as to how this class is > > supposed to be used, what does it encapsulate, etc.? > > > > At the very least a URL to a design doc or something? > > > > Also, all the methods are complete

Re: Review Request 36429: Add filesystem/linux isolator for persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36429/#review94920 --- Wouldn't it be good if we could have some comments as to how this cl

Re: Review Request 36429: Add filesystem/linux isolator for persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36429/#review93457 --- src/slave/containerizer/isolators/filesystem/linux.cpp (line 238) <

Re: Review Request 36429: Add filesystem/linux isolator for persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36429/#review93143 --- Please do a rebase first since quite a lot of the stuff have been ch

Re: Review Request 36429: Add filesystem/linux isolator for persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36429/#review91424 --- Ship it! Ship It! - Timothy Chen On July 12, 2015, 4:46 a.m., Ia

Re: Review Request 36429: Add filesystem/linux isolator for persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36429/#review91404 --- Bad patch! Reviews applied: [34136, 34908, 34137] Failed command: