Re: Review Request 36440: Update comments for mesos master cpp file

2015-07-13 Thread Marco Massenzio

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36440/#review91494
---

Ship it!


Ship It!

- Marco Massenzio


On July 13, 2015, 5:42 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36440/
> ---
> 
> (Updated July 13, 2015, 5:42 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In the function of initialize() in mesos master cpp, the comment
> of "Install handler functions for certain messages" should be moved
> to cover all install<>() functions.
> 
> This patch is making the comment also cover scheduler::call.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp b877676afa6f3833eb7d2fb06beeaa288bd8bd5d 
> 
> Diff: https://reviews.apache.org/r/36440/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>



Re: Review Request 36440: Update comments for mesos master cpp file

2015-07-12 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36440/#review91434
---


Patch looks great!

Reviews applied: [36440]

All tests passed.

- Mesos ReviewBot


On July 13, 2015, 5:42 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36440/
> ---
> 
> (Updated July 13, 2015, 5:42 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In the function of initialize() in mesos master cpp, the comment
> of "Install handler functions for certain messages" should be moved
> to cover all install<>() functions.
> 
> This patch is making the comment also cover scheduler::call.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp b877676afa6f3833eb7d2fb06beeaa288bd8bd5d 
> 
> Diff: https://reviews.apache.org/r/36440/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>