Re: Review Request 36441: Update message when master is sending offer(s)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36441/#review97146 --- This seems too tedious to fix throughout the code base in all of our logging messages, I'd suggest discarding. - Ben Mahler On Aug. 31, 2015, 11:04 a.m., Guangya Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36441/ > --- > > (Updated Aug. 31, 2015, 11:04 a.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos > > > Description > --- > > If the mesos master send only 1 offer, it should use offer but not > offers. > > This patch is updating the offers to offer(s) to be more generic. > > > Diffs > - > > src/master/master.cpp b877676afa6f3833eb7d2fb06beeaa288bd8bd5d > > Diff: https://reviews.apache.org/r/36441/diff/ > > > Testing > --- > > > Thanks, > > Guangya Liu > >
Re: Review Request 36441: Update message when master is sending offer(s)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36441/#review91439 --- Patch looks great! Reviews applied: [36441] All tests passed. - Mesos ReviewBot On July 13, 2015, 6:33 a.m., Guangya Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36441/ > --- > > (Updated July 13, 2015, 6:33 a.m.) > > > Review request for mesos. > > > Repository: mesos > > > Description > --- > > If the mesos master send only 1 offer, it should use offer but not > offers. > > This patch is updating the offers to offer(s) to be more generic. > > > Diffs > - > > src/master/master.cpp b877676afa6f3833eb7d2fb06beeaa288bd8bd5d > > Diff: https://reviews.apache.org/r/36441/diff/ > > > Testing > --- > > > Thanks, > > Guangya Liu > >
