Re: Review Request 36496: Implemented the FAILURE Event handler in the scheduler driver.

2015-07-16 Thread Vinod Kone

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36496/#review91933
---

Ship it!


Ship It!

- Vinod Kone


On July 15, 2015, 1:47 a.m., Ben Mahler wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36496/
 ---
 
 (Updated July 15, 2015, 1:47 a.m.)
 
 
 Review request for mesos and Vinod Kone.
 
 
 Bugs: MESOS-2910
 https://issues.apache.org/jira/browse/MESOS-2910
 
 
 Repository: mesos
 
 
 Description
 ---
 
 See above.
 
 
 Diffs
 -
 
   src/sched/sched.cpp e372a15db035f74d525561839b873ed659e2c33f 
   src/tests/scheduler_event_call_tests.cpp PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/36496/diff/
 
 
 Testing
 ---
 
 Added a test.
 
 
 Thanks,
 
 Ben Mahler
 




Re: Review Request 36496: Implemented the FAILURE Event handler in the scheduler driver.

2015-07-16 Thread Vinod Kone

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36496/#review91932
---



src/sched/sched.cpp (line 509)
https://reviews.apache.org/r/36496/#comment145663

TODO for refactor.



src/tests/scheduler_event_call_tests.cpp (line 170)
https://reviews.apache.org/r/36496/#comment145664

comment.


- Vinod Kone


On July 15, 2015, 1:47 a.m., Ben Mahler wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36496/
 ---
 
 (Updated July 15, 2015, 1:47 a.m.)
 
 
 Review request for mesos and Vinod Kone.
 
 
 Bugs: MESOS-2910
 https://issues.apache.org/jira/browse/MESOS-2910
 
 
 Repository: mesos
 
 
 Description
 ---
 
 See above.
 
 
 Diffs
 -
 
   src/sched/sched.cpp e372a15db035f74d525561839b873ed659e2c33f 
   src/tests/scheduler_event_call_tests.cpp PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/36496/diff/
 
 
 Testing
 ---
 
 Added a test.
 
 
 Thanks,
 
 Ben Mahler