Re: Review Request 36498: Implemented the OFFERS Event handler in the scheduler driver.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36498/#review92119 --- Ship it! Ship It! - Vinod Kone On July 17, 2015, 1:36 a.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36498/ --- (Updated July 17, 2015, 1:36 a.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-2910 and MESOS-3012 https://issues.apache.org/jira/browse/MESOS-2910 https://issues.apache.org/jira/browse/MESOS-3012 Repository: mesos Description --- This relies on 'Offer.url' to compute the pids needed for the message passing optimization (see [MESOS-3012](https://issues.apache.org/jira/browse/MESOS-3012)). Diffs - src/sched/sched.cpp 839fcbf0169fecf74fb17cab94fe4d35a1e20a10 src/tests/scheduler_event_call_tests.cpp cf6aa19a644580ff9d805e919763e9342d72677f Diff: https://reviews.apache.org/r/36498/diff/ Testing --- Added a test. Thanks, Ben Mahler
Re: Review Request 36498: Implemented the OFFERS Event handler in the scheduler driver.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36498/#review91939 --- Ship it! src/sched/sched.cpp (lines 494 - 495) https://reviews.apache.org/r/36498/#comment145685 couldn't you have used ANY which is the default? src/tests/scheduler_event_call_tests.cpp (line 176) https://reviews.apache.org/r/36498/#comment145691 This test also ensures that framework to executor messages can bypass the master right? Mind adding that here? src/tests/scheduler_event_call_tests.cpp (line 211) https://reviews.apache.org/r/36498/#comment145693 s/offers/ResourceOfferMessages/ src/tests/scheduler_event_call_tests.cpp (lines 230 - 235) https://reviews.apache.org/r/36498/#comment145694 use createTask()? src/tests/scheduler_event_call_tests.cpp (line 237) https://reviews.apache.org/r/36498/#comment145695 Why capture the executor driver when it's not used? - Vinod Kone On July 15, 2015, 1:47 a.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36498/ --- (Updated July 15, 2015, 1:47 a.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-2910 and MESOS-3012 https://issues.apache.org/jira/browse/MESOS-2910 https://issues.apache.org/jira/browse/MESOS-3012 Repository: mesos Description --- This relies on 'Offer.url' to compute the pids needed for the message passing optimization (see [MESOS-3012](https://issues.apache.org/jira/browse/MESOS-3012)). Diffs - src/sched/sched.cpp e372a15db035f74d525561839b873ed659e2c33f src/tests/scheduler_event_call_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/36498/diff/ Testing --- Added a test. Thanks, Ben Mahler
Re: Review Request 36498: Implemented the OFFERS Event handler in the scheduler driver.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36498/ --- (Updated July 17, 2015, 1:36 a.m.) Review request for mesos and Vinod Kone. Changes --- Cleanups per Vinod's review. Bugs: MESOS-2910 and MESOS-3012 https://issues.apache.org/jira/browse/MESOS-2910 https://issues.apache.org/jira/browse/MESOS-3012 Repository: mesos Description --- This relies on 'Offer.url' to compute the pids needed for the message passing optimization (see [MESOS-3012](https://issues.apache.org/jira/browse/MESOS-3012)). Diffs (updated) - src/sched/sched.cpp 839fcbf0169fecf74fb17cab94fe4d35a1e20a10 src/tests/scheduler_event_call_tests.cpp cf6aa19a644580ff9d805e919763e9342d72677f Diff: https://reviews.apache.org/r/36498/diff/ Testing --- Added a test. Thanks, Ben Mahler
Re: Review Request 36498: Implemented the OFFERS Event handler in the scheduler driver.
On July 16, 2015, 6:52 p.m., Vinod Kone wrote: src/sched/sched.cpp, lines 494-495 https://reviews.apache.org/r/36498/diff/1/?file=1011994#file1011994line494 couldn't you have used ANY which is the default? I only want to remove from the front and the end, ANY will remove from anywhere in the string. I'll use strings::trim instead, where ANY means front and back as you expected (although ANY is a bit confusing in this context :)). - Ben --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36498/#review91939 --- On July 15, 2015, 1:47 a.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36498/ --- (Updated July 15, 2015, 1:47 a.m.) Review request for mesos and Vinod Kone. Bugs: MESOS-2910 and MESOS-3012 https://issues.apache.org/jira/browse/MESOS-2910 https://issues.apache.org/jira/browse/MESOS-3012 Repository: mesos Description --- This relies on 'Offer.url' to compute the pids needed for the message passing optimization (see [MESOS-3012](https://issues.apache.org/jira/browse/MESOS-3012)). Diffs - src/sched/sched.cpp e372a15db035f74d525561839b873ed659e2c33f src/tests/scheduler_event_call_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/36498/diff/ Testing --- Added a test. Thanks, Ben Mahler
