Re: Review Request 36518: Fixed a bug in master to properly handle resubscription.

2015-07-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36518/#review91977 --- Patch looks great! Reviews applied: [36560, 36518] All tests passe

Re: Review Request 36518: Fixed a bug in master to properly handle resubscription.

2015-07-16 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36518/ --- (Updated July 16, 2015, 9:48 p.m.) Review request for mesos and Ben Mahler. C

Re: Review Request 36518: Fixed a bug in master to properly handle resubscription.

2015-07-16 Thread Vinod Kone
> On July 15, 2015, 9:38 p.m., Ben Mahler wrote: > > src/tests/scheduler_tests.cpp, line 143 > > > > > > Hm.. 'force' doesn't make sense for SUBSCRIBE without a framework id. > > > > Seems like either we: >

Re: Review Request 36518: Fixed a bug in master to properly handle resubscription.

2015-07-15 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36518/#review91821 --- Ship it! Looks good given the current Call API. However, per our ch

Re: Review Request 36518: Fixed a bug in master to properly handle resubscription.

2015-07-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36518/#review91813 --- Patch looks great! Reviews applied: [36518] All tests passed. - M