Re: Review Request 36627: Fixed cgroups oom killer and memory pressure tests on Ubuntu 14.04.

2015-08-01 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36627/ --- (Updated Aug. 1, 2015, 3:52 p.m.) Review request for mesos, Benjamin Hindman an

Re: Review Request 36627: Fixed cgroups oom killer and memory pressure tests on Ubuntu 14.04.

2015-08-01 Thread Artem Harutyunyan
> On Aug. 1, 2015, 3:30 p.m., Benjamin Hindman wrote: > > src/tests/containerizer/cgroups_tests.cpp, lines 1143-1146 > > > > > > But doesn't this mean we might stay in an infinite loop forever? I'm > > assuming tha

Re: Review Request 36627: Fixed cgroups oom killer and memory pressure tests on Ubuntu 14.04.

2015-08-01 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36627/#review93849 --- Ship it! src/tests/containerizer/cgroups_tests.cpp (lines 1143 - 1

Re: Review Request 36627: Fixed cgroups oom killer and memory pressure tests on Ubuntu 14.04.

2015-07-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36627/#review93536 --- Patch looks great! Reviews applied: [36618, 36627] All tests passe

Re: Review Request 36627: Fixed cgroups oom killer and memory pressure tests on Ubuntu 14.04.

2015-07-29 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36627/ --- (Updated July 29, 2015, 4:14 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 36627: Fixed cgroups oom killer and memory pressure tests on Ubuntu 14.04.

2015-07-29 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36627/ --- (Updated July 29, 2015, 4:11 p.m.) Review request for mesos, Benjamin Hindman a

Re: Review Request 36627: Fixed cgroups oom killer and memory pressure tests on Ubuntu 14.04.

2015-07-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36627/#review93018 --- Bad patch! Reviews applied: [36618, 36627] Failed command: ./suppo

Re: Review Request 36627: Fixed cgroups oom killer and memory pressure tests on Ubuntu 14.04.

2015-07-24 Thread Artem Harutyunyan
> On July 23, 2015, 8:02 p.m., Marco Massenzio wrote: > > src/tests/memory_test_helper.cpp, line 87 > > > > > > micro-nit: missing an `a` in `posix_memlign` Fixed in the latest commit. Thanks! - Artem ---

Re: Review Request 36627: Fixed cgroups oom killer and memory pressure tests on Ubuntu 14.04.

2015-07-24 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36627/ --- (Updated July 24, 2015, 5:32 p.m.) Review request for mesos, Benjamin Hindman a