Re: Review Request 36760: Handle scheduler pid as optional in the slave.

2015-07-24 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36760/#review93001 --- Ship it! Ship It! - Vinod Kone On July 24, 2015, 10:27 p.m., Ben

Re: Review Request 36760: Handle scheduler pid as optional in the slave.

2015-07-24 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36760/ --- (Updated July 24, 2015, 10:27 p.m.) Review request for mesos, Anand Mazumdar an

Re: Review Request 36760: Handle scheduler pid as optional in the slave.

2015-07-24 Thread Ben Mahler
> On July 24, 2015, 2:17 a.m., Anand Mazumdar wrote: > > src/slave/slave.cpp, line 1302 > > > > > > Option > > > The default constructor already initializes to None. Right, we often do this just to make it

Re: Review Request 36760: Handle scheduler pid as optional in the slave.

2015-07-24 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36760/#review92945 --- modulo anand's comments. src/messages/messages.proto (lines 347 -

Re: Review Request 36760: Handle scheduler pid as optional in the slave.

2015-07-23 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36760/#review92855 --- Looks very good ! src/messages/messages.proto (line 352)