Re: Review Request 36801: Moved containerizer related tests under src/tests/containerizer.

2015-07-27 Thread Marco Massenzio 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36801/#review93172
---


Thanks for doing this, Jie!

- Marco Massenzio


On July 24, 2015, 10:56 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36801/
> ---
> 
> (Updated July 24, 2015, 10:56 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moved containerizer related tests under src/tests/containerizer.
> 
> As we adding more and more tests, it makes sense to have a hierarchical 
> structure for our tests to improve searchablity and readability.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 93a6a7abb81543fa2c03b35d1320c404e8d62851 
>   src/tests/cgroups_isolator_tests.cpp  
>   src/tests/cgroups_tests.cpp b63d956b9dafb2c485080ff5e016e2a05f03db15 
>   src/tests/composing_containerizer_tests.cpp  
>   src/tests/containerizer_tests.cpp 9508613619de1e1b5bfdb30ce063975bd3bdb8ef 
>   src/tests/docker_containerizer_tests.cpp  
>   src/tests/docker_tests.cpp  
>   src/tests/external_containerizer_test.cpp 
> 17bfb72cbefc637d45fa26cf5b412b58059282a9 
>   src/tests/fs_tests.cpp  
>   src/tests/isolator.hpp  
>   src/tests/isolator_tests.cpp 7ad0cb643f2add636dfbb4a01495c68b2f4dfdd4 
>   src/tests/launch_tests.cpp  
>   src/tests/launcher.hpp  
>   src/tests/memory_pressure_tests.cpp  
>   src/tests/memory_test_helper.hpp  
>   src/tests/memory_test_helper.cpp 8093e66c45cacc4bf0295a3448c128a1aa7c751a 
>   src/tests/memory_test_helper_main.cpp 
> 362535fe85d84eb16d6db60c0183aa249eab5b07 
>   src/tests/ns_tests.cpp bcd0e12a302e60e602a768fd794407cce1394ea2 
>   src/tests/perf_tests.cpp  
>   src/tests/port_mapping_tests.cpp  
>   src/tests/routing_tests.cpp  
>   src/tests/sched_tests.cpp  
>   src/tests/setns_test_helper.hpp  
>   src/tests/setns_test_helper.cpp eff1e6e85a344ed9f45ae9c1c2b49bf0d265a184 
>   src/tests/setns_test_helper_main.cpp 
> 00d38166fcc44fc23093a2f50dc2f8139cdc5e74 
> 
> Diff: https://reviews.apache.org/r/36801/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 36801: Moved containerizer related tests under src/tests/containerizer.

2015-07-24 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36801/#review93005
---

Ship it!



src/Makefile.am (line 1481)


white space.



src/Makefile.am (line 1489)


ws



src/Makefile.am (line 1492)


ws


- Vinod Kone


On July 24, 2015, 10:56 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36801/
> ---
> 
> (Updated July 24, 2015, 10:56 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moved containerizer related tests under src/tests/containerizer.
> 
> As we adding more and more tests, it makes sense to have a hierarchical 
> structure for our tests to improve searchablity and readability.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 93a6a7abb81543fa2c03b35d1320c404e8d62851 
>   src/tests/cgroups_isolator_tests.cpp  
>   src/tests/cgroups_tests.cpp b63d956b9dafb2c485080ff5e016e2a05f03db15 
>   src/tests/composing_containerizer_tests.cpp  
>   src/tests/containerizer_tests.cpp 9508613619de1e1b5bfdb30ce063975bd3bdb8ef 
>   src/tests/docker_containerizer_tests.cpp  
>   src/tests/docker_tests.cpp  
>   src/tests/external_containerizer_test.cpp 
> 17bfb72cbefc637d45fa26cf5b412b58059282a9 
>   src/tests/fs_tests.cpp  
>   src/tests/isolator.hpp  
>   src/tests/isolator_tests.cpp 7ad0cb643f2add636dfbb4a01495c68b2f4dfdd4 
>   src/tests/launch_tests.cpp  
>   src/tests/launcher.hpp  
>   src/tests/memory_pressure_tests.cpp  
>   src/tests/memory_test_helper.hpp  
>   src/tests/memory_test_helper.cpp 8093e66c45cacc4bf0295a3448c128a1aa7c751a 
>   src/tests/memory_test_helper_main.cpp 
> 362535fe85d84eb16d6db60c0183aa249eab5b07 
>   src/tests/ns_tests.cpp bcd0e12a302e60e602a768fd794407cce1394ea2 
>   src/tests/perf_tests.cpp  
>   src/tests/port_mapping_tests.cpp  
>   src/tests/routing_tests.cpp  
>   src/tests/sched_tests.cpp  
>   src/tests/setns_test_helper.hpp  
>   src/tests/setns_test_helper.cpp eff1e6e85a344ed9f45ae9c1c2b49bf0d265a184 
>   src/tests/setns_test_helper_main.cpp 
> 00d38166fcc44fc23093a2f50dc2f8139cdc5e74 
> 
> Diff: https://reviews.apache.org/r/36801/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>