Re: Review Request 36837: Update gmock to 1.7.0.

2015-08-11 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/#review94974 --- 3rdparty/libprocess/3rdparty/CMakeLists.txt (line 166)

Re: Review Request 36837: Update gmock to 1.7.0.

2015-08-11 Thread Alex Clemmer
On Aug. 11, 2015, 7:06 p.m., Alex Clemmer wrote: 3rdparty/libprocess/3rdparty/CMakeLists.txt, line 166 https://reviews.apache.org/r/36837/diff/8/?file=1034022#file1034022line166 This line breaks the build on my machine OS X 10.10, and I'm not sure how to fix it because CMake's

Re: Review Request 36837: Update gmock to 1.7.0.

2015-08-11 Thread Alex Clemmer
On Aug. 11, 2015, 7:06 p.m., Alex Clemmer wrote: 3rdparty/libprocess/3rdparty/CMakeLists.txt, line 166 https://reviews.apache.org/r/36837/diff/8/?file=1034022#file1034022line166 This line breaks the build on my machine OS X 10.10, and I'm not sure how to fix it because CMake's

Re: Review Request 36837: Update gmock to 1.7.0.

2015-08-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/#review94503 --- Patch looks great! Reviews applied: [36837] All tests passed. -

Re: Review Request 36837: Update gmock to 1.7.0.

2015-08-07 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/#review94510 --- Ship it! Ship It! - Michael Park On Aug. 7, 2015, 3:24 a.m.,

Re: Review Request 36837: Update gmock to 1.7.0.

2015-08-07 Thread haosdent huang
On Aug. 7, 2015, 8:43 a.m., Michael Park wrote: Ship It! Thank you for your great help. LoL - haosdent --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/#review94510

Re: Review Request 36837: Update gmock to 1.7.0.

2015-08-06 Thread haosdent huang
On Aug. 7, 2015, midnight, Michael Park wrote: 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake, line 36 https://reviews.apache.org/r/36837/diff/7/?file=1033437#file1033437line36 `s/1.6.0/1.7.0/` Thank you very much, let me update. - haosdent

Re: Review Request 36837: Update gmock to 1.7.0.

2015-08-06 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/ --- (Updated Aug. 7, 2015, 3:24 a.m.) Review request for mesos and Michael Park.

Re: Review Request 36837: Update gmock to 1.7.0.

2015-08-06 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/#review94466 --- 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake (line 36)

Re: Review Request 36837: Update gmock to 1.7.0.

2015-08-06 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/ --- (Updated Aug. 6, 2015, 6:26 a.m.) Review request for mesos and Michael Park.

Re: Review Request 36837: Update gmock to 1.7.0.

2015-08-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/#review94396 --- Patch looks great! Reviews applied: [36837] All tests passed. -

Re: Review Request 36837: Update gmock to 1.7.0.

2015-08-06 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/ --- (Updated Aug. 6, 2015, 9:20 a.m.) Review request for mesos and Michael Park.

Re: Review Request 36837: Update gmock to 1.7.0 .

2015-08-05 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/ --- (Updated Aug. 5, 2015, 9:24 p.m.) Review request for mesos and Michael Park.

Re: Review Request 36837: Update gmock to 1.7.0 .

2015-08-05 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/ --- (Updated Aug. 6, 2015, 4:22 a.m.) Review request for mesos and Michael Park.

Re: Review Request 36837: Update gmock to 1.7.0.

2015-08-05 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/ --- (Updated Aug. 6, 2015, 5:08 a.m.) Review request for mesos and Michael Park.

Re: Review Request 36837: Update gmock to 1.7.0 .

2015-08-05 Thread haosdent huang
On Aug. 6, 2015, 3:27 a.m., Michael Park wrote: I'm also getting the following error when I run `distcheck`. Do you happen to know why? ``` ERROR: files left in build directory after distclean: ./3rdparty/libprocess/3rdparty/._gmock-1.7.0 make[1]: *** [distcleancheck] Error 1

Re: Review Request 36837: Update gmock to 1.7.0.

2015-08-05 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/ --- (Updated Aug. 6, 2015, 5:07 a.m.) Review request for mesos and Michael Park.

Re: Review Request 36837: Update gmock to 1.7.0 .

2015-08-05 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/ --- (Updated Aug. 6, 2015, 4:14 a.m.) Review request for mesos and Michael Park.

Re: Review Request 36837: Update gmock to 1.7.0 .

2015-08-05 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/#review94344 --- I'm also getting the following error when I run `distcheck`. Do you

Re: Review Request 36837: Update gmock to 1.7.0.

2015-08-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/#review94356 --- Bad patch! Reviews applied: [36837] Failed command:

Re: Review Request 36837: Update gmock to 1.7.0 .

2015-08-05 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/#review94341 --- There are also `TODO` comments from @dhamon regarding `gmock-1.7.0`

Re: Review Request 36837: Update gmock to 1.7.0 .

2015-07-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/#review93066 --- Bad patch! Reviews applied: [36837] Failed command:

Re: Review Request 36837: Update gmock to 1.7.0 .

2015-07-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/#review93067 --- Bad patch! Reviews applied: [36837] Failed command:

Re: Review Request 36837: Update gmock to 1.7.0 .

2015-07-26 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/ --- (Updated July 27, 2015, 3:48 a.m.) Review request for mesos. Bugs:

Re: Review Request 36837: Update gmock to 1.7.0 .

2015-07-26 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/ --- (Updated July 27, 2015, 4:03 a.m.) Review request for mesos. Bugs:

Re: Review Request 36837: Update gmock to 1.7.0 .

2015-07-26 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/ --- (Updated July 27, 2015, 4:18 a.m.) Review request for mesos. Bugs: