Re: Review Request 36847: Added HTTP Delete Method.

2015-08-14 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36847/#review95410 --- Ship it! Ship It! - Bernd Mathiske On Aug. 13, 2015, 9:19 a.m.,

Re: Review Request 36847: Added HTTP Delete Method.

2015-08-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36847/#review95277 --- Patch looks great! Reviews applied: [36847] All tests passed. -

Re: Review Request 36847: Added HTTP Delete Method.

2015-08-13 Thread Joerg Schad
On Aug. 6, 2015, 9:56 a.m., Alexander Rojas wrote: 3rdparty/libprocess/include/process/http.hpp, line 754 https://reviews.apache.org/r/36847/diff/7/?file=1028524#file1028524line754 I'm rather late to the party, but AFAIK Mesos appreciates consistency over doing some things right

Re: Review Request 36847: Added HTTP Delete Method.

2015-08-13 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36847/ --- (Updated Aug. 13, 2015, 4:19 p.m.) Review request for mesos, Alexander

Re: Review Request 36847: Added HTTP Delete Method.

2015-08-12 Thread Marco Massenzio
On Aug. 6, 2015, 9:56 a.m., Alexander Rojas wrote: 3rdparty/libprocess/include/process/http.hpp, line 754 https://reviews.apache.org/r/36847/diff/7/?file=1028524#file1028524line754 I'm rather late to the party, but AFAIK Mesos appreciates consistency over doing some things right

Re: Review Request 36847: Added HTTP Delete Method.

2015-08-12 Thread Bernd Mathiske
On Aug. 6, 2015, 2:56 a.m., Alexander Rojas wrote: 3rdparty/libprocess/include/process/http.hpp, line 754 https://reviews.apache.org/r/36847/diff/7/?file=1028524#file1028524line754 I'm rather late to the party, but AFAIK Mesos appreciates consistency over doing some things right

Re: Review Request 36847: Added HTTP Delete Method.

2015-08-12 Thread Bernd Mathiske
On Aug. 6, 2015, 2:56 a.m., Alexander Rojas wrote: 3rdparty/libprocess/include/process/http.hpp, line 754 https://reviews.apache.org/r/36847/diff/7/?file=1028524#file1028524line754 I'm rather late to the party, but AFAIK Mesos appreciates consistency over doing some things right

Re: Review Request 36847: Added HTTP Delete Method.

2015-08-08 Thread Marco Massenzio
On Aug. 6, 2015, 9:56 a.m., Alexander Rojas wrote: 3rdparty/libprocess/include/process/http.hpp, line 754 https://reviews.apache.org/r/36847/diff/7/?file=1028524#file1028524line754 I'm rather late to the party, but AFAIK Mesos appreciates consistency over doing some things right

Re: Review Request 36847: Added HTTP Delete Method.

2015-08-06 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36847/#review94388 --- 3rdparty/libprocess/include/process/http.hpp (line 754)

Re: Review Request 36847: Added HTTP Delete Method.

2015-08-04 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36847/#review94040 --- 3rdparty/libprocess/include/process/http.hpp (line 747)

Re: Review Request 36847: Added HTTP Delete Method.

2015-08-04 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36847/ --- (Updated Aug. 4, 2015, 10:54 a.m.) Review request for mesos, Alexander

Re: Review Request 36847: Added HTTP Delete Method.

2015-08-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36847/#review94067 --- Patch looks great! Reviews applied: [36847] All tests passed. -

Re: Review Request 36847: Added HTTP Delete Method.

2015-08-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36847/#review93998 --- Patch looks great! Reviews applied: [36847] All tests passed. -

Re: Review Request 36847: Added HTTP Delete Method.

2015-08-03 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36847/#review93880 --- 3rdparty/libprocess/include/process/http.hpp (line 736)

Re: Review Request 36847: Added HTTP Delete Method.

2015-08-03 Thread Joerg Schad
On Aug. 3, 2015, 5:47 p.m., Marco Massenzio wrote: 3rdparty/libprocess/src/http.cpp, lines 927-929 https://reviews.apache.org/r/36847/diff/4/?file=1023561#file1023561line927 I would add a statement in the (javadoc?) method's documentation, to the effect that a query or fragment

Re: Review Request 36847: Added HTTP Delete Method.

2015-08-03 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36847/ --- (Updated Aug. 3, 2015, 6:45 p.m.) Review request for mesos, Alexander

Re: Review Request 36847: Added HTTP Delete Method.

2015-08-03 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36847/#review93923 --- 3rdparty/libprocess/include/process/http.hpp (line 736)

Re: Review Request 36847: Added HTTP Delete Method.

2015-08-03 Thread Joerg Schad
On Aug. 3, 2015, 5:47 p.m., Marco Massenzio wrote: 3rdparty/libprocess/include/process/http.hpp, line 736 https://reviews.apache.org/r/36847/diff/4/?file=1023560#file1023560line736 please don't use abbreviations. `delete()` is the HTTP method name. I'm almost sure

Re: Review Request 36847: Added HTTP Delete Method.

2015-07-28 Thread Joerg Schad
On July 27, 2015, 8:13 p.m., Alexander Rukletsov wrote: 3rdparty/libprocess/src/http.cpp, line 927 https://reviews.apache.org/r/36847/diff/1/?file=1022344#file1022344line927 This todo looks inconsistent with the way `GET` handler is written. Let's create a clean-up JIRA ticket.

Re: Review Request 36847: Added HTTP Delete Method.

2015-07-28 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36847/ --- (Updated July 28, 2015, 9:49 a.m.) Review request for mesos and Alexander

Re: Review Request 36847: Added HTTP Delete Method.

2015-07-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36847/#review93271 --- Patch looks great! Reviews applied: [36847] All tests passed. -

Re: Review Request 36847: Added HTTP Delete Method.

2015-07-28 Thread Joerg Schad
On July 28, 2015, 8:43 a.m., Alexander Rukletsov wrote: Also, I think we need a doppelgänger for the method in the `streaming` namespace. Are you sure? For delete we are not streaming any data... - Joerg --- This is an

Re: Review Request 36847: Added HTTP Delete Method.

2015-07-28 Thread Alexander Rukletsov
On July 28, 2015, 8:43 a.m., Alexander Rukletsov wrote: Also, I think we need a doppelgänger for the method in the `streaming` namespace. Joerg Schad wrote: Are you sure? For delete we are not streaming any data... I think we do it implicitly anyway (see

Re: Review Request 36847: Added HTTP Delete Method.

2015-07-28 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36847/ --- (Updated July 28, 2015, 4:26 p.m.) Review request for mesos and Alexander

Re: Review Request 36847: Added HTTP Delete Method.

2015-07-28 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36847/#review93307 --- Ship it! Ship It! - Alexander Rukletsov On July 28, 2015, 4:26

Re: Review Request 36847: Added HTTP Delete Method.

2015-07-28 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36847/ --- (Updated July 28, 2015, 4:45 p.m.) Review request for mesos and Alexander

Re: Review Request 36847: Added HTTP Delete Method.

2015-07-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36847/#review93326 --- Patch looks great! Reviews applied: [36847] All tests passed. -