Re: Review Request 36889: FetcherTests: Use ASSERT instead of EXPECT if the subsequent logic relies on the outcome.

2015-07-29 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36889/ --- (Updated July 29, 2015, 1:11 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 36889: FetcherTests: Use ASSERT instead of EXPECT if the subsequent logic relies on the outcome.

2015-07-29 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36889/#review93444 --- Ship it! Ship It! - Bernd Mathiske On July 29, 2015, 6:11 a.m.,

Re: Review Request 36889: FetcherTests: Use ASSERT instead of EXPECT if the subsequent logic relies on the outcome.

2015-07-28 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36889/#review93297 --- Ship it! Ship It! - Jan Schlicht On July 28, 2015, 3:48 p.m.,

Re: Review Request 36889: FetcherTests: Use ASSERT instead of EXPECT if the subsequent logic relies on the outcome.

2015-07-28 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36889/ --- (Updated July 28, 2015, 1:48 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 36889: FetcherTests: Use ASSERT instead of EXPECT if the subsequent logic relies on the outcome.

2015-07-28 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36889/#review93288 --- src/tests/fetcher_cache_tests.cpp (line 368)

Re: Review Request 36889: FetcherTests: Use ASSERT instead of EXPECT if the subsequent logic relies on the outcome.

2015-07-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36889/#review93295 --- Patch looks great! Reviews applied: [36889] All tests passed. -

Re: Review Request 36889: FetcherTests: Use ASSERT instead of EXPECT if the subsequent logic relies on the outcome.

2015-07-28 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36889/ --- (Updated July 28, 2015, 12:52 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 36889: FetcherTests: Use ASSERT instead of EXPECT if the subsequent logic relies on the outcome.

2015-07-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36889/#review93311 --- Patch looks great! Reviews applied: [36889] All tests passed. -