Re: Review Request 36951: MESOS-3052: optimize slave ID comparisons

2015-07-30 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36951/#review93647
---


Patch looks great!

Reviews applied: [36951]

All tests passed.

- Mesos ReviewBot


On July 30, 2015, 8:43 p.m., James Peach wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/36951/
 ---
 
 (Updated July 30, 2015, 8:43 p.m.)
 
 
 Review request for mesos and Ben Mahler.
 
 
 Bugs: MESOS-3052
 https://issues.apache.org/jira/browse/MESOS-3052
 
 
 Repository: mesos
 
 
 Description
 ---
 
 MESOS-3052: optimize slave ID comparisons
 
 
 Diffs
 -
 
   src/master/allocator/mesos/hierarchical.hpp 
 e278139f856888d6c6f538f7c0f664087e97f629 
 
 Diff: https://reviews.apache.org/r/36951/diff/
 
 
 Testing
 ---
 
 Running in production for a few weeks, yields ~10% CPU reduction. Tested with 
 make check and make bench.
 
 
 Thanks,
 
 James Peach
 




Re: Review Request 36951: MESOS-3052: optimize slave ID comparisons

2015-07-30 Thread James Peach

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36951/
---

(Updated July 30, 2015, 8:43 p.m.)


Review request for mesos and Ben Mahler.


Bugs: MESOS-3052
https://issues.apache.org/jira/browse/MESOS-3052


Repository: mesos


Description
---

MESOS-3052: optimize slave ID comparisons


Diffs
-

  src/master/allocator/mesos/hierarchical.hpp 
e278139f856888d6c6f538f7c0f664087e97f629 

Diff: https://reviews.apache.org/r/36951/diff/


Testing (updated)
---

Running in production for a few weeks, yields ~10% CPU reduction. Tested with 
make check and make bench.


Thanks,

James Peach